fix(ci): restore claudeup-core to pnpm workspace to fix Test Plugins failures#2
Closed
fix(ci): restore claudeup-core to pnpm workspace to fix Test Plugins failures#2
Conversation
claudeup-core was removed from tools/pnpm-workspace.yaml but the workspace lockfile (tools/pnpm-lock.yaml) still contained claudeup-core as an importer. This mismatch caused `pnpm install` to fail in CI with a lockfile inconsistency error (runs 23779059727, 23778999927, and older). Adding claudeup-core back to pnpm-workspace.yaml aligns the workspace definition with the existing workspace lockfile, which already contains all of claudeup-core's dependencies including vitest and @vitest/coverage-v8. Fixes: Test Plugins CI failures on main (since 2026-03-28) https://claude.ai/code/session_014nwGwbkvaV8wvmb7xQmAy9
erudenko
added a commit
that referenced
this pull request
Mar 31, 2026
…n version sync Three root causes for persistent Test Plugins CI failures: 1. pnpm workspace interference: tools/pnpm-workspace.yaml only lists 'skills-api'. pnpm traverses up from tools/claudeup-core and finds this config, skipping claudeup-core's own deps. Fix: --ignore-workspace. 2. pnpm-lock.yaml in tools/claudeup-core is missing vitest and @vitest/coverage-v8 entirely (they are in package.json devDependencies but were never committed to the lockfile). With --ignore-workspace pnpm reads the local frozen lockfile and never installs vitest → 'sh: vitest: not found'. Fix: --no-frozen-lockfile so pnpm installs from package.json directly. 3. kanban version mismatch: plugins/kanban/plugin.json is 1.1.0 but .claude-plugin/marketplace.json still listed 1.0.0. The marketplace-sync integration test catches this. Fix: bump to 1.1.0 in marketplace.json. Supersedes PR #6 (which fixed #1 and #3 but not #2)."
3 tasks
Member
Author
|
Closing as superseded by PR #8 ( Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
claudeup-corewas removed fromtools/pnpm-workspace.yamlbut the workspace lockfile (tools/pnpm-lock.yaml) still declared it as an importer — this mismatch causedpnpm installto fail every time CI ran the Test Plugins workflowclaudeup-coreback to the workspace packages list aligns the definition with the lockfile, which already contains all required dependencies includingvitestand@vitest/coverage-v8Root Cause
tools/pnpm-workspace.yamllisted onlyskills-api, buttools/pnpm-lock.yamlstill had aclaudeup-coreimporter block. When GitHub Actions ranpnpm installfromtools/claudeup-core/withCI=true(which enables--frozen-lockfileby default), pnpm detected the lockfile–workspace mismatch and aborted.Affected runs: 23779059727, 23778999927, 23776816762, 23723312764, 23723077305, 23697252527, 23697213395 (all Test Plugins failures since 2026-03-28).
Test plan
pnpm installintools/claudeup-coreinstalls vitest and all devDeps without error on both Node 20 and 22https://claude.ai/code/session_014nwGwbkvaV8wvmb7xQmAy9