Skip to content

Prevent use of .. or : in file path#3552

Merged
rockfordlhotka merged 1 commit into
MarimerLLC:mainfrom
rockfordlhotka:3551-assemblyload
Nov 16, 2023
Merged

Prevent use of .. or : in file path#3552
rockfordlhotka merged 1 commit into
MarimerLLC:mainfrom
rockfordlhotka:3551-assemblyload

Conversation

@rockfordlhotka

Copy link
Copy Markdown
Member

Closes #3551

@rockfordlhotka

Copy link
Copy Markdown
Member Author

@BaHXeLiSiHg fyi, I'm requesting your review here because the code being affected exists due to a PR we worked on quite some time ago, to enable loading/unloading assemblies in memory. The result is a potential security issue that's been uncovered, and this is an attempt to resolve that by preventing loading assemblies from outside the app's bin directory tree.

@BaHXeLiSiHg BaHXeLiSiHg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, I'm okay with that.

@rockfordlhotka rockfordlhotka merged commit 2c32a57 into MarimerLLC:main Nov 16, 2023
@rockfordlhotka rockfordlhotka deleted the 3551-assemblyload branch November 16, 2023 18:19
@SamIntruder

Copy link
Copy Markdown

Hi folks,
Do you know if this issue was ever assigned a CVE identifier, and if not, could one be assigned (probably most easily using Githubs system for it, as the project has the module enabled already?)

@rockfordlhotka

Copy link
Copy Markdown
Member Author

I've never explored that concept @sampizzey, would this be in GH or NuGet?

@ajohnstone-ks

Copy link
Copy Markdown

@rockfordlhotka I just got an email b/c one of my repo's is apparently using a version of Csla which is vunerable.

https://cve.mitre.org/cgi-bin/cvename.cgi?name=2024-28698

Was this fix ever backported? It seems like it should be given the effort required to move to Csla 6+.

@rockfordlhotka

Copy link
Copy Markdown
Member Author

@rockfordlhotka I just got an email b/c one of my repo's is apparently using a version of Csla which is vunerable.

https://cve.mitre.org/cgi-bin/cvename.cgi?name=2024-28698

Was this fix ever backported? It seems like it should be given the effort required to move to Csla 6+.

#4133

@github-actions

github-actions Bot commented Aug 7, 2025

Copy link
Copy Markdown

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Prevent the use of ../ when loading assemblies

4 participants