Skip to content

Fixing time duration display#1950

Merged
phixMe merged 4 commits into
mainfrom
fix/stopwatch-duration
Apr 19, 2022
Merged

Fixing time duration display#1950
phixMe merged 4 commits into
mainfrom
fix/stopwatch-duration

Conversation

@phixMe

@phixMe phixMe commented Apr 15, 2022

Copy link
Copy Markdown
Member

Problem

This fixes the presentation of the run display.

Thanks to @mlecuyer-nd for reporting this issue.

Closes: #1949

Solution

Fixes the presentation of time and make some small enhancements as well.

Checklist

  • You've signed-off your work
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • You've updated the CHANGELOG.md with details about your change under the "Unreleased" section (if relevant, depending on the change, this may not be necessary)
  • You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)

@phixMe phixMe added review Ready for review javascript Pull requests that update Javascript code labels Apr 15, 2022
@phixMe phixMe requested a review from wslulciuc April 15, 2022 21:07
@codecov

codecov Bot commented Apr 15, 2022

Copy link
Copy Markdown

Codecov Report

Merging #1950 (49716cc) into main (6b047e1) will not change coverage.
The diff coverage is n/a.

❗ Current head 49716cc differs from pull request most recent head bb88d1e. Consider uploading reports for the commit bb88d1e to get more accurate results

@@            Coverage Diff            @@
##               main    #1950   +/-   ##
=========================================
  Coverage     78.09%   78.09%           
  Complexity      944      944           
=========================================
  Files           193      193           
  Lines          5249     5249           
  Branches        418      418           
=========================================
  Hits           4099     4099           
  Misses          705      705           
  Partials        445      445           

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@phixMe phixMe marked this pull request as ready for review April 15, 2022 21:16

@wslulciuc wslulciuc left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@wslulciuc wslulciuc removed the review Ready for review label Apr 19, 2022
@phixMe phixMe enabled auto-merge (squash) April 19, 2022 15:37
@phixMe phixMe merged commit 24786cb into main Apr 19, 2022
@phixMe phixMe deleted the fix/stopwatch-duration branch April 19, 2022 15:45
jonathanpmoraes referenced this pull request in nubank/NuMarquez Feb 6, 2025
* Fixing time module and tests.

* Better tests and constants.

Co-authored-by: phix <peter.hicks@astronomer.io>
Co-authored-by: Willy Lulciuc <willy@datakin.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

javascript Pull requests that update Javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Job Run Duration Shows incorrect time if >1 hour or >24 hours

2 participants