Fixing time duration display#1950
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1950 +/- ##
=========================================
Coverage 78.09% 78.09%
Complexity 944 944
=========================================
Files 193 193
Lines 5249 5249
Branches 418 418
=========================================
Hits 4099 4099
Misses 705 705
Partials 445 445 📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
jonathanpmoraes
referenced
this pull request
in nubank/NuMarquez
Feb 6, 2025
* Fixing time module and tests. * Better tests and constants. Co-authored-by: phix <peter.hicks@astronomer.io> Co-authored-by: Willy Lulciuc <willy@datakin.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
This fixes the presentation of the run display.
Thanks to @mlecuyer-nd for reporting this issue.
Closes: #1949
Solution
Fixes the presentation of time and make some small enhancements as well.
Checklist
CHANGELOG.mdwith details about your change under the "Unreleased" section (if relevant, depending on the change, this may not be necessary).sqldatabase schema migration according to Flyway's naming convention (if relevant)