Skip to content

Update docker-compose.yml: Randomly map postgres db port#2000

Merged
wslulciuc merged 1 commit into
MarquezProject:mainfrom
RNHTTR:main
May 20, 2022
Merged

Update docker-compose.yml: Randomly map postgres db port#2000
wslulciuc merged 1 commit into
MarquezProject:mainfrom
RNHTTR:main

Conversation

@RNHTTR

@RNHTTR RNHTTR commented May 20, 2022

Copy link
Copy Markdown
Contributor

Signed-off-by: Ryan Hatter ryan.hatter@astronomer.io

Problem

Overriding default postgres port 5432 when running Marquez alongside other applications that use port 5432

Closes: #1956

Solution

Update docker-compose.yml to randomly map postgres db port

Checklist

  • You've signed-off your work
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • You've updated the CHANGELOG.md with details about your change under the "Unreleased" section (if relevant, depending on the change, this may not be necessary)
  • You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)

Signed-off-by: Ryan Hatter <ryan.hatter@astronomer.io>
@codecov

codecov Bot commented May 20, 2022

Copy link
Copy Markdown

Codecov Report

Merging #2000 (e234c53) into main (3fbe2f9) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #2000   +/-   ##
=========================================
  Coverage     78.23%   78.23%           
  Complexity      955      955           
=========================================
  Files           194      194           
  Lines          5293     5293           
  Branches        420      420           
=========================================
  Hits           4141     4141           
  Misses          706      706           
  Partials        446      446           

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@wslulciuc wslulciuc left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@wslulciuc wslulciuc merged commit ac7a455 into MarquezProject:main May 20, 2022

@rossturk rossturk left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@collado-mike

Copy link
Copy Markdown
Collaborator

🎉

jonathanpmoraes referenced this pull request in nubank/NuMarquez Feb 6, 2025
Signed-off-by: Ryan Hatter <ryan.hatter@astronomer.io>

Co-authored-by: Ryan Hatter <ryan.hatter@astronomer.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Choose non-default port for Postgres in docker/up.sh

4 participants