Skip to content

Reduce limit for list datasets jobs in UI#2018

Merged
phixMe merged 2 commits into
mainfrom
feature/reduce-limit-for-list-datasets-jobs
Jun 14, 2022
Merged

Reduce limit for list datasets jobs in UI#2018
phixMe merged 2 commits into
mainfrom
feature/reduce-limit-for-list-datasets-jobs

Conversation

@wslulciuc

Copy link
Copy Markdown
Member

Problem

The current UI default limit to list datasets and jobs is 2000 which can be an expensive query. A more ideal approach would be to introduce paging (see #1711), but for now, let's use a reasonable default 25.

Solution

Reduce limit for list datasets jobs from 2000 to 25.

Checklist

  • You've signed-off your work
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • You've updated the CHANGELOG.md with details about your change under the "Unreleased" section (if relevant, depending on the change, this may not be necessary)
  • You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)

Signed-off-by: wslulciuc <willy@datakin.com>
Signed-off-by: wslulciuc <willy@datakin.com>
@wslulciuc wslulciuc requested a review from phixMe June 14, 2022 23:50
@codecov

codecov Bot commented Jun 14, 2022

Copy link
Copy Markdown

Codecov Report

Merging #2018 (33e0d9b) into main (c53f66c) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #2018   +/-   ##
=========================================
  Coverage     78.89%   78.89%           
  Complexity     1014     1014           
=========================================
  Files           197      197           
  Lines          5548     5548           
  Branches        421      421           
=========================================
  Hits           4377     4377           
  Misses          724      724           
  Partials        447      447           

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@phixMe phixMe left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @wslulciuc

@phixMe phixMe merged commit 48f4a60 into main Jun 14, 2022
@phixMe phixMe deleted the feature/reduce-limit-for-list-datasets-jobs branch June 14, 2022 23:51
@wslulciuc wslulciuc changed the title Reduce UI limit for list datasets jobs in UI Reduce limit for list datasets jobs in UI Jun 14, 2022
jonathanpmoraes referenced this pull request in nubank/NuMarquez Feb 6, 2025
* Set list limit for datasets and jobs to 25 by default

Signed-off-by: wslulciuc <willy@datakin.com>

* Update changelog

Signed-off-by: wslulciuc <willy@datakin.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants