Reduce limit for list datasets jobs in UI#2018
Merged
Merged
Conversation
Signed-off-by: wslulciuc <willy@datakin.com>
Signed-off-by: wslulciuc <willy@datakin.com>
Codecov Report
@@ Coverage Diff @@
## main #2018 +/- ##
=========================================
Coverage 78.89% 78.89%
Complexity 1014 1014
=========================================
Files 197 197
Lines 5548 5548
Branches 421 421
=========================================
Hits 4377 4377
Misses 724 724
Partials 447 447 📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
jonathanpmoraes
referenced
this pull request
in nubank/NuMarquez
Feb 6, 2025
* Set list limit for datasets and jobs to 25 by default Signed-off-by: wslulciuc <willy@datakin.com> * Update changelog Signed-off-by: wslulciuc <willy@datakin.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The current UI default limit to list datasets and jobs is
2000which can be an expensive query. A more ideal approach would be to introduce paging (see #1711), but for now, let's use a reasonable default25.Solution
Reduce limit for list datasets jobs from
2000to25.Checklist
CHANGELOG.mdwith details about your change under the "Unreleased" section (if relevant, depending on the change, this may not be necessary).sqldatabase schema migration according to Flyway's naming convention (if relevant)