Fix/symlinked jobs in queries#2053
Merged
Merged
Conversation
Signed-off-by: Michael Collado <collado.mike@gmail.com>
Signed-off-by: Michael Collado <collado.mike@gmail.com>
Signed-off-by: Michael Collado <collado.mike@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #2053 +/- ##
=========================================
Coverage 78.79% 78.79%
Complexity 1011 1011
=========================================
Files 200 200
Lines 5573 5573
Branches 422 422
=========================================
Hits 4391 4391
Misses 730 730
Partials 452 452 📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
wslulciuc
reviewed
Aug 1, 2022
wslulciuc
approved these changes
Aug 1, 2022
wslulciuc
left a comment
wslulciuc
left a comment
Member
There was a problem hiding this comment.
Minor comment on testing, otherwise LGTM 👍
Signed-off-by: Michael Collado <collado.mike@gmail.com>
collado-mike
force-pushed
the
fix/symlinked_jobs_in_queries
branch
from
0085f3e to
48130fe
Compare
Collaborator
Author
|
Build is repeatedly failing due to adoptium/adoptium-support#554 . I've gone ahead and merged the PR and we can watch the related issue |
7 tasks
jonathanpmoraes
referenced
this pull request
in nubank/NuMarquez
Feb 6, 2025
* Update jobs update function to dedupe aliases Signed-off-by: Michael Collado <collado.mike@gmail.com> * Update search query to accommodate symlinked jobs and aliases Signed-off-by: Michael Collado <collado.mike@gmail.com> * Update lineage query to include symlinked jobs in lineage Signed-off-by: Michael Collado <collado.mike@gmail.com> * Updated search test to validate symlink target jobs are returned Signed-off-by: Michael Collado <collado.mike@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A few fixes for the lineage query and the search queries related to symlinked jobs. These changes ensure that old and new jobs are found (users can search for aliases) and that new jobs continue to participate in the lineage of old jobs before they have new runs (previously, a job would have no lineage until that job was actually run).
Checklist
CHANGELOG.mdwith details about your change under the "Unreleased" section (if relevant, depending on the change, this may not be necessary).sqldatabase schema migration according to Flyway's naming convention (if relevant)