Skip to content

Fix py module release#2057

Merged
wslulciuc merged 2 commits into
mainfrom
bug/fix-py-release
Aug 2, 2022
Merged

Fix py module release#2057
wslulciuc merged 2 commits into
mainfrom
bug/fix-py-release

Conversation

@wslulciuc

@wslulciuc wslulciuc commented Aug 2, 2022

Copy link
Copy Markdown
Member

Problem

Our py modules release fails as the result of applying the bump2version cmd twice in new-version.sh (see failed release CI job):

  File "setup.py", line 27
    version="version="0.24.0"",
                         ^
SyntaxError: invalid syntax

Exited with code exit status 1

Solution

Only bump the py module version when preparing the next development version.

Checklist

  • You've signed-off your work
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • You've updated the CHANGELOG.md with details about your change under the "Unreleased" section (if relevant, depending on the change, this may not be necessary)
  • You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)
  • You've included a header in any source code files (if relevant)

Signed-off-by: wslulciuc <willy@datakin.com>
Signed-off-by: wslulciuc <willy@datakin.com>
@wslulciuc wslulciuc requested a review from merobi-hub August 2, 2022 22:08
@wslulciuc wslulciuc enabled auto-merge (squash) August 2, 2022 22:09

@merobi-hub merobi-hub left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @wslulciuc

@wslulciuc wslulciuc merged commit 272ecb6 into main Aug 2, 2022
@wslulciuc wslulciuc deleted the bug/fix-py-release branch August 2, 2022 22:11
jonathanpmoraes referenced this pull request in nubank/NuMarquez Feb 6, 2025
* Remove release steps on creating/drafting a new project board

Signed-off-by: wslulciuc <willy@datakin.com>

* Add new line

Signed-off-by: wslulciuc <willy@datakin.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants