doc:openapi Improve documentation on spec's nodeId#2084
Merged
Conversation
- adds more example and details on what nodeId. - updated description of the nodeId. Signed-off-by: howardyoo <howardyoo@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #2084 +/- ##
=========================================
Coverage 77.04% 77.04%
Complexity 1013 1013
=========================================
Files 201 201
Lines 4643 4643
Branches 389 389
=========================================
Hits 3577 3577
Misses 628 628
Partials 438 438 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
wslulciuc
reviewed
Aug 23, 2022
Signed-off-by: howardyoo <howardyoo@gmail.com>
jonathanpmoraes
referenced
this pull request
in nubank/NuMarquez
Feb 6, 2025
* This PR is for MarquezProject/marquez#2083 - adds more example and details on what nodeId. - updated description of the nodeId. Signed-off-by: howardyoo <howardyoo@gmail.com> * fixed the example part of the nodId Signed-off-by: howardyoo <howardyoo@gmail.com> Signed-off-by: howardyoo <howardyoo@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: howardyoo howardyoo@gmail.com
Problem
The current spec description lacks complete examples of the format and example of nodeId.
Closes: #2083
Solution
Checklist
CHANGELOG.mdwith details about your change under the "Unreleased" section (if relevant, depending on the change, this may not be necessary).sqldatabase schema migration according to Flyway's naming convention (if relevant)