Add metadata cmd#2091
Merged
Merged
Conversation
Signed-off-by: wslulciuc <willy@datakin.com>
Signed-off-by: wslulciuc <willy@datakin.com>
Signed-off-by: wslulciuc <willy@datakin.com>
Signed-off-by: wslulciuc <willy@datakin.com>
Signed-off-by: wslulciuc <willy@datakin.com>
Codecov Report
@@ Coverage Diff @@
## main #2091 +/- ##
============================================
- Coverage 77.04% 74.94% -2.10%
- Complexity 1013 1017 +4
============================================
Files 201 202 +1
Lines 4643 4789 +146
Branches 389 393 +4
============================================
+ Hits 3577 3589 +12
- Misses 628 762 +134
Partials 438 438
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: wslulciuc <willy@datakin.com>
Signed-off-by: wslulciuc <willy@datakin.com>
Signed-off-by: wslulciuc <willy@datakin.com>
…uez into feature/metadata-cmd
fm100
reviewed
Aug 26, 2022
Signed-off-by: wslulciuc <willy@datakin.com>
fm100
approved these changes
Aug 26, 2022
jonathanpmoraes
referenced
this pull request
in nubank/NuMarquez
Feb 6, 2025
* Add metadata.json to .gitignore Signed-off-by: wslulciuc <willy@datakin.com> * Add psql conf for pghero Signed-off-by: wslulciuc <willy@datakin.com> * Add pghero Signed-off-by: wslulciuc <willy@datakin.com> * Add metadata cmd Signed-off-by: wslulciuc <willy@datakin.com> * Update javadocs Signed-off-by: wslulciuc <willy@datakin.com> * Add steps to enable query stats with pghero Signed-off-by: wslulciuc <willy@datakin.com> * Give pghero superuser access Signed-off-by: wslulciuc <willy@datakin.com> * Update cmd arg constant for --bytes-per-event Signed-off-by: wslulciuc <willy@datakin.com> * Simplify newOlEvents() Signed-off-by: wslulciuc <willy@datakin.com> Signed-off-by: wslulciuc <willy@datakin.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
There's currently no good way to performance test the data model of Marquez with significantly large OL events (see #2076).
Solution
Add cmd
metadatato generate OpenLineage events; generated events will be saved to a file calledmetadata.jsonthat can be used to seed Marquez via theseedcmd (sweet, right!?):When seeding Marquez with generated events, we can now observe query performance via
pghero. When running:containers,
marquez-api,marquez-web,marquez-dband nowpgherowill start. Query stats aren't enabled by default, you'll need to manually enable query profiling via the UI by browsing tohttp://localhost:8080:Limitations of
metadatacmdAs follow up work, well want to:
--inputs-per-event/--outputs-per-event5...N)Checklist
CHANGELOG.mdwith details about your change under the "Unreleased" section (if relevant, depending on the change, this may not be necessary).sqldatabase schema migration according to Flyway's naming convention (if relevant)