Skip to content

Fix version bump in docker/up.sh#2129

Merged
wslulciuc merged 8 commits into
mainfrom
bug/version-bump-in-docker-up.sh
Sep 20, 2022
Merged

Fix version bump in docker/up.sh#2129
wslulciuc merged 8 commits into
mainfrom
bug/version-bump-in-docker-up.sh

Conversation

@wslulciuc

@wslulciuc wslulciuc commented Sep 20, 2022

Copy link
Copy Markdown
Member

Problem

The latest tag in docker/up.sh isn't updated.

Solution

Define a VERSION variable docker/up.sh to bump on a release.

Checklist

  • You've signed-off your work
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • You've updated the CHANGELOG.md with details about your change under the "Unreleased" section (if relevant, depending on the change, this may not be necessary)
  • You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)
  • You've included a header in any source code files (if relevant)

Signed-off-by: wslulciuc <willy@datakin.com>
Signed-off-by: wslulciuc <willy@datakin.com>
Signed-off-by: wslulciuc <willy@datakin.com>
@codecov

codecov Bot commented Sep 20, 2022

Copy link
Copy Markdown

Codecov Report

Merging #2129 (4ae6714) into main (e61fe48) will not change coverage.
The diff coverage is n/a.

❗ Current head 4ae6714 differs from pull request most recent head 3302e51. Consider uploading reports for the commit 3302e51 to get more accurate results

@@            Coverage Diff            @@
##               main    #2129   +/-   ##
=========================================
  Coverage     75.30%   75.30%           
  Complexity     1038     1038           
=========================================
  Files           203      203           
  Lines          4883     4883           
  Branches        399      399           
=========================================
  Hits           3677     3677           
  Misses          763      763           
  Partials        443      443           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@merobi-hub merobi-hub left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@wslulciuc wslulciuc marked this pull request as ready for review September 20, 2022 21:39
Signed-off-by: wslulciuc <willy@datakin.com>
Signed-off-by: wslulciuc <willy@datakin.com>
Signed-off-by: wslulciuc <willy@datakin.com>
Signed-off-by: wslulciuc <willy@datakin.com>
Signed-off-by: wslulciuc <willy@datakin.com>
@boring-cyborg boring-cyborg Bot added the chart label Sep 20, 2022
@wslulciuc wslulciuc enabled auto-merge (squash) September 20, 2022 22:26
@wslulciuc wslulciuc merged commit b608fae into main Sep 20, 2022
@wslulciuc wslulciuc deleted the bug/version-bump-in-docker-up.sh branch September 20, 2022 22:33
@wslulciuc wslulciuc changed the title Bug/version bump in docker up.sh Fix version bump in docker up.sh Sep 20, 2022
@wslulciuc wslulciuc changed the title Fix version bump in docker up.sh Fix version bump in docker/up.sh Sep 20, 2022
jonathanpmoraes referenced this pull request in nubank/NuMarquez Feb 6, 2025
* Bump version in .env.example

Signed-off-by: wslulciuc <willy@datakin.com>

* Remove version bump of docker/up.sh in new-version.sh

Signed-off-by: wslulciuc <willy@datakin.com>

* Use VERSION in docker/up.sh

Signed-off-by: wslulciuc <willy@datakin.com>

* Add version bump via VERSION

Signed-off-by: wslulciuc <willy@datakin.com>

* continued: Add version bump via VERSION

Signed-off-by: wslulciuc <willy@datakin.com>

* Fix version bump for docker/up.sh and .env.example

Signed-off-by: wslulciuc <willy@datakin.com>

* Revert version bump for psql

Signed-off-by: wslulciuc <willy@datakin.com>

Signed-off-by: wslulciuc <willy@datakin.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants