Add parentRun alias to LineageEvent RunFacet to support older OpenLin…#2130
Merged
Conversation
…eage events Signed-off-by: Michael Collado <collado.mike@gmail.com>
Signed-off-by: Michael Collado <collado.mike@gmail.com>
6490f57 to
d083146
Compare
wslulciuc
approved these changes
Sep 21, 2022
jonathanpmoraes
referenced
this pull request
in nubank/NuMarquez
Feb 6, 2025
…… (#2130) * Add parentRun alias to LineageEvent RunFacet to support older OpenLineage events Signed-off-by: Michael Collado <collado.mike@gmail.com> * Add changelog update Signed-off-by: Michael Collado <collado.mike@gmail.com> Signed-off-by: Michael Collado <collado.mike@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Prior to OpenLineage/OpenLineage#1037 , all Airflow OpenLineage events reported their parent runs as
parentRunrather than the spec-definedparentfacet. This change adds an alias to support those older events.Unfortunately, jackson seems to prefer the alias field name rather than the target (or maybe it's ordered on some condition I don't understand), so if an event defines both, the
parentRunfacet will be used. This is confirmed in a unit test. The OpenLineage integration does use the same value for bothparentRunandparentfacets, so this should not cause any issues.Checklist
CHANGELOG.mdwith details about your change under the "Unreleased" section (if relevant, depending on the change, this may not be necessary).sqldatabase schema migration according to Flyway's naming convention (if relevant)