Use clean when running shadowJar in Dockerfile#2145
Merged
Conversation
Signed-off-by: wslulciuc <willy@datakin.com>
Signed-off-by: wslulciuc <willy@datakin.com>
Codecov Report
@@ Coverage Diff @@
## main #2145 +/- ##
=========================================
Coverage 75.30% 75.30%
Complexity 1038 1038
=========================================
Files 203 203
Lines 4883 4883
Branches 399 399
=========================================
Hits 3677 3677
Misses 763 763
Partials 443 443 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: wslulciuc <willy@datakin.com>
mobuchowski
approved these changes
Sep 27, 2022
jonathanpmoraes
referenced
this pull request
in nubank/NuMarquez
Feb 6, 2025
* Add clean to build cmd for docker Signed-off-by: wslulciuc <willy@datakin.com> * Remove MARQUEZ_VERSION usage in docker/entrypoint.sh Signed-off-by: wslulciuc <willy@datakin.com> Signed-off-by: wslulciuc <willy@datakin.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
PR #2032 introduced
MARQUEZ_VERSIONinentrypoint.shto avoid the case when multiple JARs are located under the directoryapi/build/libs/. When building the docker image for the API, we copy over the directoryapi/in its entirety. This results in (possibly) multiple JARs with the following error:Solution
When building the API docker image, use
cleanwhen building the shadow JAR:This will ensure the directory
api/build/libs/is cleaned before building the JAR again. This PR also updates.dockerignoreto ignoreapi/build/*.Checklist
CHANGELOG.mdwith details about your change under the "Unreleased" section (if relevant, depending on the change, this may not be necessary).sqldatabase schema migration according to Flyway's naming convention (if relevant)