Display current run state for job node in lineage graph#2146
Merged
phixMe merged 9 commits intoSep 30, 2022
Conversation
Signed-off-by: wslulciuc <willy@datakin.com>
Signed-off-by: wslulciuc <willy@datakin.com>
Signed-off-by: wslulciuc <willy@datakin.com>
Signed-off-by: wslulciuc <willy@datakin.com>
Codecov Report
@@ Coverage Diff @@
## main #2146 +/- ##
=========================================
Coverage 75.78% 75.78%
Complexity 1061 1061
=========================================
Files 209 209
Lines 5006 5006
Branches 403 403
=========================================
Hits 3794 3794
Misses 763 763
Partials 449 449 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
phixMe
reviewed
Sep 28, 2022
phixMe
reviewed
Sep 28, 2022
Comment on lines
+35
to
+37
| warning: { | ||
| main: '#7D7D7D' | ||
| }, |
Member
There was a problem hiding this comment.
Typically, this would be an orange or yellow in a design system.
Member
Author
There was a problem hiding this comment.
I was referencing the colors defined in helpers/runs.ts. Also, maybe I should just use runColorMap defined in runs.ts?
Contributor
|
Thanks for working on UI @wslulciuc ❤️ |
phixMe
reviewed
Sep 29, 2022
phixMe
deleted the
feature/display-current-run-state-for-job-in-lineage-graph
branch
jonathanpmoraes
referenced
this pull request
in nubank/NuMarquez
Feb 6, 2025
* Change casing for datasets / jobs page and rename latest runtime column Signed-off-by: wslulciuc <willy@datakin.com> * Change casing for job / dataset display pages Signed-off-by: wslulciuc <willy@datakin.com> * Add mappings for node color to run state Signed-off-by: wslulciuc <willy@datakin.com> * continued: Add mappings for node color to run state Signed-off-by: wslulciuc <willy@datakin.com> * Color adjustments. * Color adjustments and prettier. * Fixing prettier. Signed-off-by: wslulciuc <willy@datakin.com> Co-authored-by: phix <peter.hicks@astronomer.io> Co-authored-by: Peter Hicks <phixMe@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
To view the current run state of a job, you have to select the job node in the lineage graph, then navigate the run info tab.
Solution
This PR fills job nodes in the lineage graph with the latest run state; this PR also makes some minor changes to column names used to display dataset and job metadata.
Checklist
CHANGELOG.mdwith details about your change under the "Unreleased" section (if relevant, depending on the change, this may not be necessary).sqldatabase schema migration according to Flyway's naming convention (if relevant)