Fix bug that caused a single run event to create multiple jobs#2162
Merged
Conversation
Signed-off-by: Michael Collado <collado.mike@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #2162 +/- ##
============================================
+ Coverage 75.78% 75.82% +0.03%
- Complexity 1061 1063 +2
============================================
Files 209 209
Lines 5006 5013 +7
Branches 403 403
============================================
+ Hits 3794 3801 +7
Misses 763 763
Partials 449 449
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jonathanpmoraes
referenced
this pull request
in nubank/NuMarquez
Feb 6, 2025
Signed-off-by: Michael Collado <collado.mike@gmail.com> Signed-off-by: Michael Collado <collado.mike@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Michael Collado collado.mike@gmail.com
Problem
As described in #2158 a single run may send multiple run events, where the start event contains a parent run and subsequent events do not. In that case, the subsequent jobs will create a new job without a parent, causing duplicate jobs with the same name.
Closes: #2158
Solution
During OpenLineage event handling, check to see if a run with the given id already exists. If it does, do not create a new job (or parent), but simply use the job that is already associated with the run.
Checklist
CHANGELOG.mdwith details about your change under the "Unreleased" section (if relevant, depending on the change, this may not be necessary).sqldatabase schema migration according to Flyway's naming convention (if relevant)