fix column lineage returning multiple entries for job run multiple times#2176
Merged
Merged
Conversation
Signed-off-by: Pawel Leszczynski <leszczynski.pawel@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #2176 +/- ##
=========================================
Coverage 76.33% 76.33%
Complexity 1099 1099
=========================================
Files 214 214
Lines 5139 5139
Branches 407 407
=========================================
Hits 3923 3923
Misses 762 762
Partials 454 454
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
mobuchowski
approved these changes
Oct 10, 2022
jonathanpmoraes
referenced
this pull request
in nubank/NuMarquez
Feb 6, 2025
…mes (#2176) Signed-off-by: Pawel Leszczynski <leszczynski.pawel@gmail.com> Signed-off-by: Pawel Leszczynski <leszczynski.pawel@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Pawel Leszczynski leszczynski.pawel@gmail.com
Problem
Each column lineage row contains columns:
output_dataset_version_uuid,output_dataset_field_uuid,input_dataset_version_uuid,input_dataset_field_uuid. This means that in case of a single job reading one column and writing to another, if a job is run twice this will result in two rows incolumn-lineagetable. This is fine as we want to track this information. But we shouldn't retrieve this twice through the endpoint.Solution
Return column dependency only once if a job has been run several times.
Checklist
CHANGELOG.mdwith details about your change under the "Unreleased" section (if relevant, depending on the change, this may not be necessary).sqldatabase schema migration according to Flyway's naming convention (if relevant)