Update jobs_current_version_uuid_index and jobs_symlink_target_uuid_index to ignore NULL values#2186
Merged
Merged
Conversation
…ndex to ignore NULL values Signed-off-by: Michael Collado <collado.mike@gmail.com>
ad1fafd to
c581ebc
Compare
Codecov Report
@@ Coverage Diff @@
## main #2186 +/- ##
=========================================
Coverage 76.60% 76.60%
Complexity 1136 1136
=========================================
Files 219 219
Lines 5287 5287
Branches 420 420
=========================================
Hits 4050 4050
Misses 765 765
Partials 472 472 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jonathanpmoraes
referenced
this pull request
in nubank/NuMarquez
Feb 6, 2025
…ndex to ignore NULL values (#2186) Signed-off-by: Michael Collado <collado.mike@gmail.com> Signed-off-by: Michael Collado <collado.mike@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Most jobs don't have a symlink target and jobs don't have a current version until they've had at least one successful run. The indices recently added will always write to the index, even when the indexed values are null.
Solution
Avoid writing to the indices when indexed values are null
Checklist
CHANGELOG.mdwith details about your change under the "Unreleased" section (if relevant, depending on the change, this may not be necessary).sqldatabase schema migration according to Flyway's naming convention (if relevant)