Skip to content

Show facets even when dataset has no fields. #2214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pawel-big-lebowski merged 1 commit into from
Oct 27, 2022
Merged

Show facets even when dataset has no fields. #2214

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions web/src/components/datasets/DatasetInfo.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,10 @@ interface DatasetInfoProps {
const DatasetInfo: FunctionComponent<DatasetInfoProps> = props => {
const { datasetFields, facets, run } = props

if (datasetFields.length === 0) {
return <MqEmpty title={'No Fields'} body={'Try adding dataset fields.'} />
}

return (
<Box>
{datasetFields.length === 0 && <MqEmpty title={'No Fields'} body={'Try adding dataset fields.'} />}
{datasetFields.length > 0 && (
<Table size='small'>
<TableHead>
<TableRow>
Expand All @@ -53,6 +51,7 @@ const DatasetInfo: FunctionComponent<DatasetInfoProps> = props => {
})}
</TableBody>
</Table>
)}
{facets && (
<Box mt={2}>
<Box mb={1}>
Expand Down
⚡