Skip to content

UI: Raw Event Viewer#2249

Merged
mobuchowski merged 7 commits into
MarquezProject:mainfrom
tito12:events
Nov 30, 2022
Merged

UI: Raw Event Viewer#2249
mobuchowski merged 7 commits into
MarquezProject:mainfrom
tito12:events

Conversation

@tito12

@tito12 tito12 commented Nov 15, 2022

Copy link
Copy Markdown
Contributor

Problem

Events existed in the API but there is no way to view them through the UI.
Related to task #2166

Solution

Events page was added with ability to filter by date and expanding payload by clicking on each event.

Screenshot at Nov 29 18-31-17

Checklist

  • You've signed-off your work
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • You've updated the CHANGELOG.md with details about your change under the "Unreleased" section (if relevant, depending on the change, this may not be necessary)
  • You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)
  • You've included a header in any source code files (if relevant)

@boring-cyborg boring-cyborg Bot added the web label Nov 15, 2022
@boring-cyborg

boring-cyborg Bot commented Nov 15, 2022

Copy link
Copy Markdown

Thanks for opening your first pull request in the Marquez project! Please check out our contributing guidelines (https://github.com/MarquezProject/marquez/blob/main/CONTRIBUTING.md).

@mobuchowski mobuchowski requested a review from phixMe November 15, 2022 17:35
@wslulciuc

wslulciuc commented Nov 15, 2022

Copy link
Copy Markdown
Member

Great to see progress on UI changes, @tito12! Before we can merge your PR, you'll need to sign your commits (see Sign Your Work). Mind also adding UI screenshots to your PR description as well?

@codecov

codecov Bot commented Nov 16, 2022

Copy link
Copy Markdown

Codecov Report

Merging #2249 (0ddd98c) into main (ce4ac65) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #2249   +/-   ##
=========================================
  Coverage     76.47%   76.47%           
  Complexity     1113     1113           
=========================================
  Files           216      216           
  Lines          5203     5203           
  Branches        421      421           
=========================================
  Hits           3979     3979           
  Misses          752      752           
  Partials        472      472           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Signed-off-by: tito1212 <vladyslav.sedenko@getindata.com>
@howardyoo

Copy link
Copy Markdown
Contributor

Just wanted to say, from the looks of it, this looks great!

@phixMe phixMe left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Great! A few suggestions for you.

Comment thread web/package.json
Comment thread web/src/routes/events/Events.tsx Outdated
Comment thread web/src/routes/events/Events.tsx Outdated
Comment thread web/src/store/requests/events.ts Outdated
Comment thread web/src/routes/events/Events.tsx Outdated
Comment thread web/src/routes/events/Events.tsx Outdated
Comment thread web/src/routes/events/Events.tsx Outdated
…te components and utils

Signed-off-by: tito1212 <vladyslav.sedenko@getindata.com>
Signed-off-by: tito1212 <vladyslav.sedenko@getindata.com>
@mobuchowski mobuchowski self-requested a review November 30, 2022 15:31
@mobuchowski mobuchowski merged commit f3b1cbd into MarquezProject:main Nov 30, 2022
@boring-cyborg

boring-cyborg Bot commented Nov 30, 2022

Copy link
Copy Markdown

Great job! Congrats on your first merged pull request in the Marquez project!

@wslulciuc wslulciuc mentioned this pull request Dec 5, 2022
jonathanpmoraes referenced this pull request in nubank/NuMarquez Feb 6, 2025
* UI: Raw Event Viewer

Signed-off-by: tito1212 <vladyslav.sedenko@getindata.com>

* Changes after review. Pagination. Ability to download payload. Separate components and utils

Signed-off-by: tito1212 <vladyslav.sedenko@getindata.com>

* Change order of imports

Signed-off-by: tito1212 <vladyslav.sedenko@getindata.com>

Signed-off-by: tito1212 <vladyslav.sedenko@getindata.com>
Co-authored-by: tito1212 <vladyslav.sedenko@getindata.com>
Co-authored-by: Maciej Obuchowski <obuchowski.maciej@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants