Include error message for JSON processing exception#2271
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2271 +/- ##
============================================
+ Coverage 76.74% 76.82% +0.07%
- Complexity 1150 1154 +4
============================================
Files 219 220 +1
Lines 5260 5268 +8
Branches 423 423
============================================
+ Hits 4037 4047 +10
+ Misses 748 747 -1
+ Partials 475 474 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: Pawel Leszczynski <leszczynski.pawel@gmail.com>
ccf4b5b to
39830fb
Compare
mobuchowski
approved these changes
Nov 30, 2022
jonathanpmoraes
referenced
this pull request
in nubank/NuMarquez
Feb 6, 2025
Signed-off-by: Pawel Leszczynski <leszczynski.pawel@gmail.com> Signed-off-by: Pawel Leszczynski <leszczynski.pawel@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Pawel Leszczynski leszczynski.pawel@gmail.com
Problem
When using a python client, a RunEvent does not validate a date time provided as a string. It's pretty easy to make an error like:
which returns:
which could be more meaningful to find a cause of an issue.
Following improvements should be done:
Closes: #2270
Solution
JsonProcessingException, Marquez should include exception in returned error message.Checklist
CHANGELOG.mdwith details about your change under the "Unreleased" section (if relevant, depending on the change, this may not be necessary).sqldatabase schema migration according to Flyway's naming convention (if relevant)