Allow null column type in column-lineage#2272
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2272 +/- ##
============================================
+ Coverage 76.82% 76.84% +0.01%
Complexity 1154 1154
============================================
Files 220 220
Lines 5268 5268
Branches 423 423
============================================
+ Hits 4047 4048 +1
Misses 747 747
+ Partials 474 473 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
9913f00 to
f47d4c1
Compare
f47d4c1 to
00066f2
Compare
JDarDagran
approved these changes
Dec 1, 2022
Signed-off-by: Pawel Leszczynski <leszczynski.pawel@gmail.com>
00066f2 to
a14140b
Compare
mobuchowski
approved these changes
Dec 1, 2022
jonathanpmoraes
referenced
this pull request
in nubank/NuMarquez
Feb 6, 2025
Signed-off-by: Pawel Leszczynski <leszczynski.pawel@gmail.com> Signed-off-by: Pawel Leszczynski <leszczynski.pawel@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Pawel Leszczynski leszczynski.pawel@gmail.com
Problem
Column lineage endpoint throw an exception when no data type of the field provided.
Closes: #2261
Solution
Write a test for this scenario, allow null.
Checklist
CHANGELOG.mdwith details about your change under the "Unreleased" section (if relevant, depending on the change, this may not be necessary).sqldatabase schema migration according to Flyway's naming convention (if relevant)