Update helm Ingress template to be cross-compatible with recent k8s versions#2275
Merged
wslulciuc merged 4 commits intoDec 5, 2022
Merged
Conversation
Signed-off-by: John Lukenoff <johnlukenoff@asana.com>
Signed-off-by: John Lukenoff <johnlukenoff@asana.com>
|
Thanks for opening your first pull request in the Marquez project! Please check out our contributing guidelines (https://github.com/MarquezProject/marquez/blob/main/CONTRIBUTING.md). |
Codecov Report
@@ Coverage Diff @@
## main #2275 +/- ##
=========================================
Coverage 76.84% 76.84%
Complexity 1154 1154
=========================================
Files 220 220
Lines 5268 5268
Branches 423 423
=========================================
Hits 4048 4048
Misses 747 747
Partials 473 473 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
wslulciuc
approved these changes
Dec 5, 2022
wslulciuc
left a comment
Member
There was a problem hiding this comment.
Thanks for the fix, @jlukenoff! 💯 🥇
FYI, would be great to have version checks for other templates within our chart as well (vs hardcoding them).
|
Great job! Congrats on your first merged pull request in the Marquez project! |
jonathanpmoraes
referenced
this pull request
in nubank/NuMarquez
Feb 6, 2025
…ersions (#2275) * Update ingress template to render conditionally based on k8s version Signed-off-by: John Lukenoff <johnlukenoff@asana.com> * Extraneous end Signed-off-by: John Lukenoff <johnlukenoff@asana.com> Signed-off-by: John Lukenoff <johnlukenoff@asana.com> Co-authored-by: Willy Lulciuc <willy@datakin.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
👋 Thanks for opening a pull request! Please include a brief summary of the problem your change is trying to solve, or bug fix. If your change fixes a bug or you'd like to provide context on why you're making the change, please link the issue as follows:
Closes: #2274
Solution
Certain components of the Ingress schema have changed in recent versions of Kubernetes. This PR updates the Ingress helm template to render based on the semantic kubernetes version.
Checklist
CHANGELOG.mdwith details about your change under the "Unreleased" section (if relevant, depending on the change, this may not be necessary).sqldatabase schema migration according to Flyway's naming convention (if relevant)