fix column lineage when multiple jobs write to same dataset#2289
Merged
pawel-big-lebowski merged 1 commit intoDec 7, 2022
Merged
Conversation
7f7a754 to
8a2bd5a
Compare
Codecov Report
@@ Coverage Diff @@
## main #2289 +/- ##
============================================
+ Coverage 76.84% 76.97% +0.13%
- Complexity 1154 1163 +9
============================================
Files 220 222 +2
Lines 5268 5298 +30
Branches 423 423
============================================
+ Hits 4048 4078 +30
Misses 747 747
Partials 473 473
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
8a2bd5a to
5e3ce84
Compare
Member
|
@pawel-big-lebowski, per our discussion offline, we'll want to:
We'll also want to make the breaking changes above in separate (minor) releases and communicate that in our changelog / release notes on their deprecation / removal. |
1b768e4 to
ace6fe0
Compare
ace6fe0 to
e988542
Compare
e988542 to
17fb0f7
Compare
mobuchowski
approved these changes
Dec 7, 2022
Signed-off-by: Pawel Leszczynski <leszczynski.pawel@gmail.com>
17fb0f7 to
a7ecf04
Compare
jonathanpmoraes
referenced
this pull request
in nubank/NuMarquez
Feb 6, 2025
Signed-off-by: Pawel Leszczynski <leszczynski.pawel@gmail.com> Signed-off-by: Pawel Leszczynski <leszczynski.pawel@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Pawel Leszczynski leszczynski.pawel@gmail.com
Problem
Current model of column-lineage API does not suit well scenario such that multiple different jobs write to same column of output dataset. Specifically, a response of the form:
should be converted into:
with
transformationDescriptionandtransformationTypecontained per input field.Solution
transformationDescriptionandtransformationType,Checklist
CHANGELOG.mdwith details about your change under the "Unreleased" section (if relevant, depending on the change, this may not be necessary).sqldatabase schema migration according to Flyway's naming convention (if relevant)