Fix asset loading for web#2323
Merged
Merged
Conversation
added 2 commits
December 13, 2022 11:28
Codecov Report
@@ Coverage Diff @@
## main #2323 +/- ##
=========================================
Coverage 76.72% 76.72%
Complexity 1177 1177
=========================================
Files 222 222
Lines 5354 5354
Branches 429 429
=========================================
Hits 4108 4108
Misses 768 768
Partials 478 478 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
phixMe
commented
Dec 14, 2022
| export = content; | ||
| } | ||
|
|
||
| declare module '*.svg'; |
Member
Author
There was a problem hiding this comment.
Potentially add other asset types here in the future, .jpg .png for example.
wslulciuc
approved these changes
Dec 14, 2022
Member
|
@phixMe, looks like you'll have to sign your commits, but otherwise this looks great! |
jonathanpmoraes
referenced
this pull request
in nubank/NuMarquez
Feb 6, 2025
* Updates for assets. * Newline. Co-authored-by: phix <peter.hicks@astronomer.io> Co-authored-by: Willy Lulciuc <willy@datakin.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Since we updated the webpack version our asset loading broke and this has resulted in us having to make some undesirable changes to load images from remote instead of local sources.
Solution
This fixes the webpack configuration and allows for files to be imported in a more modern capacity that enforces the assets actually exist.
Checklist
CHANGELOG.mdwith details about your change under the "Unreleased" section (if relevant, depending on the change, this may not be necessary).sqldatabase schema migration according to Flyway's naming convention (if relevant)