Conversation
…rmation about license Signed-off-by: tito12 <vladyslav.sedenko@gmail.com>
Signed-off-by: tito12 <vladyslav.sedenko@gmail.com>
Signed-off-by: tito12 <vladyslav.sedenko@gmail.com>
Signed-off-by: tito12 <vladyslav.sedenko@gmail.com>
Signed-off-by: tito12 <vladyslav.sedenko@gmail.com>
@tito12, can you provide some background as to why we are forking |
This package has most of functions which we need but not all, and specifically this one suit better for our requirements. There are no solution with all of these functionality and it not make sense to create solution like this package from scratch. |
|
I'd really prefer a solution here that doesn't fork a repo. What does this look like if we just use the library out of the box entirely? |
This package not contain search functionality and clickable links, which is important due task requirments. |
Signed-off-by: tito12 <vladyslav.sedenko@gmail.com>
Signed-off-by: tito12 <vladyslav.sedenko@gmail.com>
Signed-off-by: tito12 <vladyslav.sedenko@gmail.com>
… patch-package unused logic Signed-off-by: tito12 <vladyslav.sedenko@gmail.com>
|
@phixMe please take a look, I linked github repo with fork as we discussed. Thanks! |
Signed-off-by: tito12 <vladyslav.sedenko@gmail.com>
Signed-off-by: tito12 <vladyslav.sedenko@gmail.com>
Signed-off-by: tito12 <vladyslav.sedenko@gmail.com>
Signed-off-by: tito12 <vladyslav.sedenko@gmail.com>
…hub" This reverts commit 8c5eab2.
Signed-off-by: tito12 <vladyslav.sedenko@gmail.com>
Signed-off-by: tito12 <vladyslav.sedenko@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #2336 +/- ##
=========================================
Coverage 77.11% 77.11%
Complexity 1234 1234
=========================================
Files 228 228
Lines 5572 5572
Branches 447 447
=========================================
Hits 4297 4297
Misses 775 775
Partials 500 500 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@phixMe please review :) |
Signed-off-by: tito12 <vladyslav.sedenko@gmail.com>
Signed-off-by: tito12 <vladyslav.sedenko@gmail.com>
Signed-off-by: tito12 <vladyslav.sedenko@gmail.com>
* Json View component, forked package react-json-view and changes, information about license Signed-off-by: tito12 <vladyslav.sedenko@gmail.com> * fix config jest test env Signed-off-by: tito12 <vladyslav.sedenko@gmail.com> * jsonView component for jobs page Signed-off-by: tito12 <vladyslav.sedenko@gmail.com> * fix eslint for external modules Signed-off-by: tito12 <vladyslav.sedenko@gmail.com> * remove empty line Signed-off-by: tito12 <vladyslav.sedenko@gmail.com> * Move to patch-package solution and remove module code Signed-off-by: tito12 <vladyslav.sedenko@gmail.com> * Remove alias for package in webpack Signed-off-by: tito12 <vladyslav.sedenko@gmail.com> * Eslint fix Signed-off-by: tito12 <vladyslav.sedenko@gmail.com> * Link repo with package searchable-react-json-view from github. Remove patch-package unused logic Signed-off-by: tito12 <vladyslav.sedenko@gmail.com> * Remove unused code Signed-off-by: tito12 <vladyslav.sedenko@gmail.com> * Remove unused code Signed-off-by: tito12 <vladyslav.sedenko@gmail.com> * Add git to docker to be able to download npm package from github Signed-off-by: tito12 <vladyslav.sedenko@gmail.com> * Revert "Add git to docker to be able to download npm package from github" This reverts commit 8c5eab23aa870a187a594510492e6dcd86284a56. * Change new package url from git style to simple link Signed-off-by: tito12 <vladyslav.sedenko@gmail.com> * Add git to docker to be able to download npm package from github Signed-off-by: tito12 <vladyslav.sedenko@gmail.com> * Remove unused code. Move all json view to new component Signed-off-by: tito12 <vladyslav.sedenko@gmail.com> * Revert file eslintignore Signed-off-by: tito12 <vladyslav.sedenko@gmail.com> --------- Signed-off-by: tito12 <vladyslav.sedenko@gmail.com>
Problem
Now facets are just simple printed JSON, without ability to search, navigate and click on links.
Related to task #2165
Solution
Created dynamic component basen on forked solution and extended, with ability to search through json and navigate easy, expand data and ability to click links.
Checklist
CHANGELOG.mdwith details about your change under the "Unreleased" section (if relevant, depending on the change, this may not be necessary).sqldatabase schema migration according to Flyway's naming convention (if relevant)