Skip to content

Use docker-compose.web.yml as base compose file#2360

Merged
wslulciuc merged 1 commit into
mainfrom
bug/docker-up-web-ui-error
Jan 14, 2023
Merged

Use docker-compose.web.yml as base compose file#2360
wslulciuc merged 1 commit into
mainfrom
bug/docker-up-web-ui-error

Conversation

@wslulciuc

Copy link
Copy Markdown
Member

Problem

When the web UI is enabled running docker/up.sh, the Marquez HTTP server is not set correctly:

marquez-web-1               | [HPM] Proxy created: /api/v1  -> http://undefined:undefined/
marquez-web-1               | App listening on port 3000!

Solution

Use docker-compose.web.yml as base compose file, with overrides for dev set via docker-compose.web-dev.yml.

Checklist

  • You've signed-off your work
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • You've updated the CHANGELOG.md with details about your change under the "Unreleased" section (if relevant, depending on the change, this may not be necessary)
  • You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)
  • You've included a header in any source code files (if relevant)

Signed-off-by: wslulciuc <willy@datakin.com>
@boring-cyborg boring-cyborg Bot added the docker label Jan 14, 2023
@wslulciuc wslulciuc enabled auto-merge (squash) January 14, 2023 00:26
@wslulciuc wslulciuc merged commit 5424cfd into main Jan 14, 2023
@wslulciuc wslulciuc deleted the bug/docker-up-web-ui-error branch January 14, 2023 00:31
@codecov

codecov Bot commented Jan 14, 2023

Copy link
Copy Markdown

Codecov Report

Merging #2360 (2f4201c) into main (5cae3ff) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #2360   +/-   ##
=========================================
  Coverage     76.72%   76.72%           
  Complexity     1177     1177           
=========================================
  Files           222      222           
  Lines          5354     5354           
  Branches        429      429           
=========================================
  Hits           4108     4108           
  Misses          768      768           
  Partials        478      478           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

jonathanpmoraes referenced this pull request in nubank/NuMarquez Feb 6, 2025
Signed-off-by: wslulciuc <willy@datakin.com>

Signed-off-by: wslulciuc <willy@datakin.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants