Handle null job.latestRun before runStateColor#2467
Merged
pawel-big-lebowski merged 4 commits intoApr 17, 2023
Conversation
Signed-off-by: Perttu Salonen <perttu.salonen@gmail.com>
Signed-off-by: Perttu Salonen <perttu.salonen@gmail.com>
Signed-off-by: Perttu Salonen <perttu.salonen@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #2467 +/- ##
============================================
- Coverage 83.60% 83.53% -0.07%
+ Complexity 1213 1207 -6
============================================
Files 231 231
Lines 5520 5503 -17
Branches 266 267 +1
============================================
- Hits 4615 4597 -18
Misses 762 762
- Partials 143 144 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
phixMe
approved these changes
Apr 3, 2023
phixMe
left a comment
Member
There was a problem hiding this comment.
Thanks for the contribution, looks good.
Xavier-Cliquennois
pushed a commit
to Xavier-Cliquennois/marquez
that referenced
this pull request
Jul 26, 2023
* Handle null `job.latestRun` before `runStateColor` Signed-off-by: Perttu Salonen <perttu.salonen@gmail.com> * generate default color with `NEW` `runState` Signed-off-by: Perttu Salonen <perttu.salonen@gmail.com> * added changelog description Signed-off-by: Perttu Salonen <perttu.salonen@gmail.com> --------- Signed-off-by: Perttu Salonen <perttu.salonen@gmail.com> Signed-off-by: Xavier-Cliquennois <xavier.cliquennois@wearegraphite.io>
jonathanpmoraes
referenced
this pull request
in nubank/NuMarquez
Feb 6, 2025
* Handle null `job.latestRun` before `runStateColor` Signed-off-by: Perttu Salonen <perttu.salonen@gmail.com> * generate default color with `NEW` `runState` Signed-off-by: Perttu Salonen <perttu.salonen@gmail.com> * added changelog description Signed-off-by: Perttu Salonen <perttu.salonen@gmail.com> --------- Signed-off-by: Perttu Salonen <perttu.salonen@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Fixes a bug where Jobs view fails to load where some jobs don't have
latestRunCloses: #2462
Solution
Handle null
job.latestRunbefore callingrunStateColorand conditionally format the label.One-line summary:
Checklist
CHANGELOG.md(Depending on the change, this may not be necessary)..sqldatabase schema migration according to Flyway's naming convention (if relevant)