Skip to content

Handle null job.latestRun before runStateColor#2467

Merged
pawel-big-lebowski merged 4 commits into
MarquezProject:mainfrom
perttus:fix/runstatecolor
Apr 17, 2023
Merged

Handle null job.latestRun before runStateColor#2467
pawel-big-lebowski merged 4 commits into
MarquezProject:mainfrom
perttus:fix/runstatecolor

Conversation

@perttus

@perttus perttus commented Apr 3, 2023

Copy link
Copy Markdown

Problem

Fixes a bug where Jobs view fails to load where some jobs don't have latestRun

Closes: #2462

Solution

Handle null job.latestRun before calling runStateColor and conditionally format the label.

One-line summary:

Checklist

  • You've signed-off your work
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • You've included a one-line summary of your change for the CHANGELOG.md (Depending on the change, this may not be necessary).
  • You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)
  • You've included a header in any source code files (if relevant)

perttus2 added 2 commits April 3, 2023 10:34
Signed-off-by: Perttu Salonen <perttu.salonen@gmail.com>
Signed-off-by: Perttu Salonen <perttu.salonen@gmail.com>
@boring-cyborg boring-cyborg Bot added the web label Apr 3, 2023
Signed-off-by: Perttu Salonen <perttu.salonen@gmail.com>
@boring-cyborg boring-cyborg Bot added the docs label Apr 3, 2023
@codecov

codecov Bot commented Apr 3, 2023

Copy link
Copy Markdown

Codecov Report

Merging #2467 (27ad949) into main (c038f73) will decrease coverage by 0.07%.
The diff coverage is 89.47%.

❗ Current head 27ad949 differs from pull request most recent head 135553e. Consider uploading reports for the commit 135553e to get more accurate results

@@             Coverage Diff              @@
##               main    #2467      +/-   ##
============================================
- Coverage     83.60%   83.53%   -0.07%     
+ Complexity     1213     1207       -6     
============================================
  Files           231      231              
  Lines          5520     5503      -17     
  Branches        266      267       +1     
============================================
- Hits           4615     4597      -18     
  Misses          762      762              
- Partials        143      144       +1     
Impacted Files Coverage Δ
...a/marquez/db/migrations/V57_1__BackfillFacets.java 85.96% <89.47%> (-4.58%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@wslulciuc wslulciuc left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @perttus, these changes look great! @phixMe mind also looking over the UI fix?

@phixMe phixMe left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, looks good.

@pawel-big-lebowski pawel-big-lebowski merged commit a972c04 into MarquezProject:main Apr 17, 2023
@perttus perttus deleted the fix/runstatecolor branch April 17, 2023 08:46
Xavier-Cliquennois pushed a commit to Xavier-Cliquennois/marquez that referenced this pull request Jul 26, 2023
* Handle null `job.latestRun` before `runStateColor`

Signed-off-by: Perttu Salonen <perttu.salonen@gmail.com>

* generate default color with `NEW` `runState`

Signed-off-by: Perttu Salonen <perttu.salonen@gmail.com>

* added changelog description

Signed-off-by: Perttu Salonen <perttu.salonen@gmail.com>

---------

Signed-off-by: Perttu Salonen <perttu.salonen@gmail.com>
Signed-off-by: Xavier-Cliquennois <xavier.cliquennois@wearegraphite.io>
jonathanpmoraes referenced this pull request in nubank/NuMarquez Feb 6, 2025
* Handle null `job.latestRun` before `runStateColor`

Signed-off-by: Perttu Salonen <perttu.salonen@gmail.com>

* generate default color with `NEW` `runState`

Signed-off-by: Perttu Salonen <perttu.salonen@gmail.com>

* added changelog description

Signed-off-by: Perttu Salonen <perttu.salonen@gmail.com>

---------

Signed-off-by: Perttu Salonen <perttu.salonen@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Jobs/main page view fails to load

5 participants