Skip to content

Handle null run.jobVersion in DatasetInfo #2471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pawel-big-lebowski merged 4 commits into from
Apr 17, 2023
Merged

Handle null run.jobVersion in DatasetInfo #2471

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
141f7ab
handle null run.jobVersion
perttus2 Apr 5, 2023
a360e02
updated changelog
perttus2 Apr 5, 2023
e32f088
Merge branch 'main' into fix/null-run-jobversion
perttus2 Apr 17, 2023
2c93e5e
Merge branch 'main' into fix/null-run-jobversion
perttus2 Apr 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

### Fixed

* UI: Handle null `run.jobVersion` in `DatasetInfo.tsx` to fix rendering issues.
* UI: better handling of null job latestRun for Jobs page [#2467](https://github.com/MarquezProject/marquez/pull/2467) [@perttus](https://github.com/perttus)

### Added
Expand Down
2 changes: 1 addition & 1 deletion web/src/components/datasets/DatasetInfo.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ const DatasetInfo: FunctionComponent<DatasetInfoProps> = props => {
<MqText subdued>{stopWatchDuration(run.durationMs)}</MqText>
</Box>
</Box>
<MqText subdued>{run.jobVersion.name}</MqText>
<MqText subdued>{run.jobVersion && run.jobVersion.name}</MqText>
</Box>
{<MqCode code={(jobFacets?.sql as SqlFacet)?.query} language={'sql'}/>}
</Box>
Expand Down
⚡