Removed unnecessary copy command from dockerfile#2516
Merged
wslulciuc merged 1 commit intoJun 14, 2023
Conversation
Signed-off-by: Nisarg-Chokshi <nisarg4000@gmail.com>
|
Thanks for opening your first pull request in the Marquez project! Please check out our contributing guidelines (https://github.com/MarquezProject/marquez/blob/main/CONTRIBUTING.md). |
wslulciuc
approved these changes
Jun 14, 2023
wslulciuc
left a comment
Member
There was a problem hiding this comment.
Sooo redundant! Nice catch, @Nisarg-Chokshi ! 💯
Codecov Report
@@ Coverage Diff @@
## main #2516 +/- ##
=========================================
Coverage 83.80% 83.80%
Complexity 1233 1233
=========================================
Files 235 235
Lines 5625 5625
Branches 270 270
=========================================
Hits 4714 4714
Misses 767 767
Partials 144 144 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Great job! Congrats on your first merged pull request in the Marquez project! |
Xavier-Cliquennois
pushed a commit
to Xavier-Cliquennois/marquez
that referenced
this pull request
Jul 26, 2023
Signed-off-by: Nisarg-Chokshi <nisarg4000@gmail.com> Signed-off-by: Xavier-Cliquennois <xavier.cliquennois@wearegraphite.io>
jonathanpmoraes
referenced
this pull request
in nubank/NuMarquez
Feb 6, 2025
Signed-off-by: Nisarg-Chokshi <nisarg4000@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
👋 Thanks for opening a pull request! Please include a brief summary of the problem your change is trying to solve, or bug fix. If your change fixes a bug or you'd like to provide context on why you're making the change, please link the issue as follows:
Closes: #ISSUE-NUMBER
Solution
Please describe your change as it relates to the problem, or bug fix, as well as any dependencies. If your change requires a database schema migration, please describe the schema modification(s) and whether it's a backwards-incompatible or backwards-compatible change.
One-line summary:
COPYcommand for the entireapifolder. Thebuild.gradlewill eventually be added as well.Checklist
CHANGELOG.md(Depending on the change, this may not be necessary)..sqldatabase schema migration according to Flyway's naming convention (if relevant)