[fix] Resolve issue data quality assertion facet are not displayed#2528
Merged
wslulciuc merged 2 commits intoMay 7, 2024
Merged
[fix] Resolve issue data quality assertion facet are not displayed#2528wslulciuc merged 2 commits into
wslulciuc merged 2 commits into
Conversation
|
Thanks for opening your first pull request in the Marquez project! Please check out our contributing guidelines (https://github.com/MarquezProject/marquez/blob/main/CONTRIBUTING.md). |
Signed-off-by: sophiely <ly.sophie200@gmail.com>
|
Is the assertion supposed to be like this without the DataQualityAssertion or it is a mistake ? |
✅ Deploy Preview for peppy-sprite-186812 canceled.
|
jonathanpmoraes
referenced
this pull request
in nubank/NuMarquez
Feb 6, 2025
Signed-off-by: sophiely <ly.sophie200@gmail.com> Co-authored-by: Willy Lulciuc <willy@datakin.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
DataQualityAssertion facet are not displayed anymore du to the recent changes where we only display type: dataset and unknown.
Closes: #2503
Solution
We can display dataset of type
dataset,unknownandinput.Checklist
CHANGELOG.md(Depending on the change, this may not be necessary)..sqldatabase schema migration according to Flyway's naming convention (if relevant)