Slow Dataset Query Updates#2534
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2534 +/- ##
=========================================
Coverage 83.86% 83.86%
Complexity 1245 1245
=========================================
Files 238 238
Lines 5657 5657
Branches 271 271
=========================================
Hits 4744 4744
Misses 769 769
Partials 144 144
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
wslulciuc
reviewed
Jul 5, 2023
Member
There was a problem hiding this comment.
@phixMe, great work on identifying ways to optimize our dataset query! But, mind adding a query plan, or analysis of the query before and after? I agree with the changes, but also think an analysis would be helpful to better understand the change.
wslulciuc
approved these changes
Jul 17, 2023
wslulciuc
left a comment
Member
There was a problem hiding this comment.
We discussed offline, these changes look great! Thanks for the perf improvements 💯
jonathanpmoraes
referenced
this pull request
in nubank/NuMarquez
Feb 6, 2025
* Updating the sql for dataset get by name and namespace, and list endpoint * Update for test failure. * Adding qualifiers back in to list query --------- Co-authored-by: phix <peter.hicks@astronomer.io> Co-authored-by: Willy Lulciuc <willy@datakin.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
These queries were slow for Marquez instances with many datasets, dataset versions, and facets.
Solution
These queries were slow for Marquez instances with many datasets, dataset versions, and facets.
One-line summary: Scopes down nested facet queries to be the same scope as the outer query.
Checklist
CHANGELOG.md(Depending on the change, this may not be necessary)..sqldatabase schema migration according to Flyway's naming convention (if relevant)