Skip to content

Runs state indices#2535

Merged
phixMe merged 10 commits into
mainfrom
indices/run-states
Jul 17, 2023
Merged

Runs state indices#2535
phixMe merged 10 commits into
mainfrom
indices/run-states

Conversation

@phixMe

@phixMe phixMe commented Jun 30, 2023

Copy link
Copy Markdown
Member

One-line summary: Adds 4 indices to help run retention faster.

Checklist

  • You've signed-off your work
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • You've included a one-line summary of your change for the CHANGELOG.md (Depending on the change, this may not be necessary).
  • You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)
  • You've included a header in any source code files (if relevant)

@boring-cyborg boring-cyborg Bot added the api API layer changes label Jun 30, 2023
Comment thread api/src/main/resources/marquez/db/migration/V62__run_state_indices.sql Outdated
@codecov

codecov Bot commented Jul 13, 2023

Copy link
Copy Markdown

Codecov Report

Merging #2535 (882ee47) into main (52b70a7) will not change coverage.
The diff coverage is n/a.

❗ Current head 882ee47 differs from pull request most recent head f8e35d2. Consider uploading reports for the commit f8e35d2 to get more accurate results

@@            Coverage Diff            @@
##               main    #2535   +/-   ##
=========================================
  Coverage     83.86%   83.86%           
  Complexity     1245     1245           
=========================================
  Files           238      238           
  Lines          5657     5657           
  Branches        271      271           
=========================================
  Hits           4744     4744           
  Misses          769      769           
  Partials        144      144           

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Comment thread api/src/main/resources/marquez/db/migration/V62__run_state_indices.sql Outdated

@wslulciuc wslulciuc left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments on naming conventions, otherwise 👍

@phixMe phixMe enabled auto-merge (squash) July 17, 2023 22:27
@phixMe phixMe merged commit 3d023e4 into main Jul 17, 2023
@phixMe phixMe deleted the indices/run-states branch July 17, 2023 22:36
jonathanpmoraes referenced this pull request in nubank/NuMarquez Feb 6, 2025
* Runs state indices

* If not exists.

* Adding newline

* Rename

* Renaming indices

* Uppercase.

* Newline

---------

Co-authored-by: phix <peter.hicks@astronomer.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api API layer changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants