Define DbRetentionJob(Jdbi, DbRetentionConfig)

[wslulciuc]

Problem

Validate DbRetentionConfig properties internally within class. That is, when instantiating a new DbRetentionConfig object, the caller should expect all config values to be valid, contain a reasonable default (if not set), and be immutable. The caller should not be expected to validate the properties externally from the class.

Solution

Add @Positive to DbRetentionConfig instance variables with accompanying test suite.

Checklist

• You've signed-off your work
• Your changes are accompanied by tests (if relevant)
• Your change contains a small diff and is self-contained
• You've updated any relevant documentation (if relevant)
• You've included a one-line summary of your change for the CHANGELOG.md (Depending on the change, this may not be necessary).
• You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)
• You've included a header in any source code files (if relevant)

[codecov]

Codecov Report

Merging #2549 (1cfeb9e) into main (a515c91) will increase coverage by 0.15%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##               main    #2549      +/-   ##
============================================
+ Coverage     83.15%   83.30%   +0.15%     
  Complexity     1286     1286              
============================================
  Files           244      243       -1     
  Lines          5942     5931      -11     
  Branches        282      279       -3     
============================================
  Hits           4941     4941              
+ Misses          854      843      -11     
  Partials        147      147              

Impacted Files	Coverage Δ
api/src/main/java/marquez/MarquezApp.java	69.04% <0.00%> (+3.13%)	⬆️
api/src/main/java/marquez/jobs/DbRetentionJob.java	0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[phixMe]

Nice validation, Thanks for this.