Skip to content

Add log for when retention job starts#2551

Merged
wslulciuc merged 2 commits into
mainfrom
feature/log-when-retention-job-starts
Jul 25, 2023
Merged

Add log for when retention job starts#2551
wslulciuc merged 2 commits into
mainfrom
feature/log-when-retention-job-starts

Conversation

@wslulciuc

@wslulciuc wslulciuc commented Jul 25, 2023

Copy link
Copy Markdown
Member

Problem

Let's add a log event when the DbRetentionJob starts. The log will display:

  • Retention policy
  • Run frequency

Solution

INFO  [2023-07-25 13:47:10,615] marquez.jobs.DbRetentionJob: Started db retention job with retention policy of '7' days, scheduled to be applied every '1' mins.

Checklist

  • You've signed-off your work
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • You've included a one-line summary of your change for the CHANGELOG.md (Depending on the change, this may not be necessary).
  • You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)
  • You've included a header in any source code files (if relevant)

Signed-off-by: wslulciuc <willy@datakin.com>
@boring-cyborg boring-cyborg Bot added the api API layer changes label Jul 25, 2023
Signed-off-by: wslulciuc <willy@datakin.com>
@wslulciuc wslulciuc requested a review from phixMe July 25, 2023 13:51
@codecov

codecov Bot commented Jul 25, 2023

Copy link
Copy Markdown

Codecov Report

Merging #2551 (2c6861c) into main (3aa0b5b) will decrease coverage by 0.05%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##               main    #2551      +/-   ##
============================================
- Coverage     83.30%   83.26%   -0.05%     
  Complexity     1286     1286              
============================================
  Files           243      243              
  Lines          5931     5934       +3     
  Branches        279      279              
============================================
  Hits           4941     4941              
- Misses          843      846       +3     
  Partials        147      147              
Files Changed Coverage Δ
api/src/main/java/marquez/jobs/DbRetentionJob.java 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@wslulciuc wslulciuc enabled auto-merge (squash) July 25, 2023 15:25

@phixMe phixMe left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@wslulciuc wslulciuc merged commit 8a61feb into main Jul 25, 2023
@wslulciuc wslulciuc deleted the feature/log-when-retention-job-starts branch July 25, 2023 15:25
jonathanpmoraes referenced this pull request in nubank/NuMarquez Feb 6, 2025
* Add log for when retention job starts

Signed-off-by: wslulciuc <willy@datakin.com>

---------

Signed-off-by: wslulciuc <willy@datakin.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api API layer changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants