Skip to content

Adding the IO Tab#2613

Merged
wslulciuc merged 5 commits into
mainfrom
feature/web/inputs-outputs
Sep 25, 2023
Merged

Adding the IO Tab#2613
wslulciuc merged 5 commits into
mainfrom
feature/web/inputs-outputs

Conversation

@phixMe

@phixMe phixMe commented Sep 12, 2023

Copy link
Copy Markdown
Member

Problem

For large graphs users wish to navigate the graph without clicking on the graph itself because it's hard to do with many edges that are not able to be displayed.

One-line summary:
Adds a new tab to move between graph elements without looking at the graph itself.

image

image

Checklist

  • You've signed-off your work
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • You've included a one-line summary of your change for the CHANGELOG.md (Depending on the change, this may not be necessary).
  • You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)
  • You've included a header in any source code files (if relevant)

@boring-cyborg boring-cyborg Bot added the web label Sep 12, 2023
phix added 2 commits September 19, 2023 11:52
@codecov

codecov Bot commented Sep 19, 2023

Copy link
Copy Markdown

Codecov Report

Merging #2613 (ab2addf) into main (6003af6) will not change coverage.
The diff coverage is n/a.

❗ Current head ab2addf differs from pull request most recent head 170e158. Consider uploading reports for the commit 170e158 to get more accurate results

@@            Coverage Diff            @@
##               main    #2613   +/-   ##
=========================================
  Coverage     83.33%   83.33%           
  Complexity     1291     1291           
=========================================
  Files           244      244           
  Lines          5940     5940           
  Branches        279      279           
=========================================
  Hits           4950     4950           
  Misses          844      844           
  Partials        146      146           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Comment thread web/src/components/datasets/DatasetDetailPage.tsx Outdated
Comment thread web/src/components/jobs/JobDetailPage.tsx Outdated
@wslulciuc

Copy link
Copy Markdown
Member

@phixMe so much great work here to make traversing very large lineage graph easier (or at least, more intuitive). I have some minor feedback on how I see users interacting with the "list" view in a more intuitive way:

  1. Under the I/O tab, when I click an IN or OUT edge, I would navigate the user to the I/O tab of the selected node

  2. When a user selects a node under the I/O tab, I'd be great also recenter the graph if the node is not in the current lineage view. I'm not sure on the effort required to do this, so not a must give we do update which edges and nodes are highlight as the user navigates the I/O tab.

  3. I'm wondering if we should indicate no IN or OUT edges exist? Currently, it might seem that the `OUT edges are "missing" rather than just not defined.

    Screen Shot 2023-09-22 at 3 17 42 PM

@phixMe

phixMe commented Sep 25, 2023

Copy link
Copy Markdown
Member Author

So, we don't have graph recentering available to us, I made an update for the other two items.

@phixMe phixMe marked this pull request as ready for review September 25, 2023 20:09

@wslulciuc wslulciuc left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ❤️

@wslulciuc wslulciuc enabled auto-merge (squash) September 25, 2023 23:46
@wslulciuc wslulciuc merged commit 45b7281 into main Sep 25, 2023
@wslulciuc wslulciuc deleted the feature/web/inputs-outputs branch September 25, 2023 23:56
jonathanpmoraes referenced this pull request in nubank/NuMarquez Feb 6, 2025
* Adding the IO Tab.

* Removing logs.

* Updates for code review.

---------

Co-authored-by: phix <peter.hicks@astronomer.io>
Co-authored-by: Willy Lulciuc <willy@datakin.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants