Migrate Docker Compose cmd in up to V2#2644
Merged
Merged
Conversation
Signed-off-by: merobi-hub <merobi@gmail.com>
✅ Deploy Preview for peppy-sprite-186812 canceled.
|
Codecov Report
@@ Coverage Diff @@
## main #2644 +/- ##
=========================================
Coverage 83.35% 83.35%
Complexity 1295 1295
=========================================
Files 244 244
Lines 5948 5948
Branches 279 279
=========================================
Hits 4958 4958
Misses 844 844
Partials 146 146 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jonathanpmoraes
referenced
this pull request
in nubank/NuMarquez
Feb 6, 2025
Signed-off-by: merobi-hub <merobi@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Docker Compose version 1 has been at EOL since this past June. Our docker compose
upcommand in docker/up.sh is technically not compatible with version 2, even if Docker Desktop for Mac (or Docker for MacOS in general?) permits the incorrect format. On at least one Linux distro, however, the command fails to execute when version 2 is installed. Error output mentions only MIME-type issues, which is confusing and unhelpful, making the issue hard to diagnose. New users on Linux can potentially be blocked by this.Solution
This upgrades the
upcommand in docker/up.sh to version 2. This should be sufficient to migrate the project.Closes: #2643
One-line summary: upgrades docker/up.sh to Docker Compose V2
Checklist
CHANGELOG.md(Depending on the change, this may not be necessary)..sqldatabase schema migration according to Flyway's naming convention (if relevant)