Add dataset field level tags to UI#2729
Conversation
Signed-off-by: sharpd <number6labs@gmail.com>
✅ Deploy Preview for peppy-sprite-186812 canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2729 +/- ##
=========================================
Coverage 84.45% 84.45%
Complexity 1416 1416
=========================================
Files 251 251
Lines 6447 6447
Branches 291 291
=========================================
Hits 5445 5445
Misses 850 850
Partials 152 152 ☔ View full report in Codecov by Sentry. |
Signed-off-by: sharpd <number6labs@gmail.com>
Signed-off-by: sharpd <number6labs@gmail.com>
| const handleOpen = (key: string) => { | ||
| setOpen(true) | ||
| setSelectedKey(key) | ||
| localStorage.setItem(`dsi_${dsNamespace}_${dsName}`, JSON.stringify(newExpandedRows)) |
There was a problem hiding this comment.
I kind of want to get away from doing this because it doesn't move across urls. Could we possibly use use parameters for functionality like this?
| </Collapse> | ||
| </TableCell> | ||
| </TableRow> | ||
| </React.Fragment> |
There was a problem hiding this comment.
From a UI perspective, I think it may be perhaps better to have tags that are already part of a dataset listed.
For new tags, I think a dialog would be pretty nice for this.
Signed-off-by: sharpd <number6labs@gmail.com>
Signed-off-by: sharpd <number6labs@gmail.com>
phixMe
left a comment
There was a problem hiding this comment.
Thanks @davidsharp7 This looks good now. We're going to have a merge conflict with the larger changes across the board, I may want to hold off merging this unless you need it immediately.
Cool, cool - No giant rush from me @phixMe @wslulciuc . |
Signed-off-by: sharpd <davidsharp7@gmail.com>
Signed-off-by: sharpd <davidsharp7@gmail.com>
Signed-off-by: sharpd <davidsharp7@gmail.com>
* add dataset field level tags in UI Signed-off-by: sharpd <number6labs@gmail.com> * set Auto Complete to small Signed-off-by: sharpd <number6labs@gmail.com> * add decription to dataset tags if exits Signed-off-by: sharpd <number6labs@gmail.com> * update dataset tags based on feedback Signed-off-by: sharpd <number6labs@gmail.com> * change button icon/add translation/add additional var to tooltip Signed-off-by: sharpd <number6labs@gmail.com> * add formatting to menu items to enhance readability Signed-off-by: sharpd <davidsharp7@gmail.com> * more formatting changes to list drop down Signed-off-by: sharpd <davidsharp7@gmail.com> * update dataset details to remove readonly Signed-off-by: sharpd <davidsharp7@gmail.com> --------- Signed-off-by: sharpd <number6labs@gmail.com> Signed-off-by: sharpd <davidsharp7@gmail.com> Co-authored-by: sharpd <number6labs@gmail.com>


Problem
Currently the UI has no ability to add and delete tags at the field level. The proposed solution is update the DatasetTags component to allow for field level tagging/deletion and add this to the DatasetInfo component.
Closes: #2728
Solution
Update DatasetTags to include field level tagging in the UI.
One-line summary:
Update DatasetTags to include field level tagging in the UI
Checklist
CHANGELOG.md(Depending on the change, this may not be necessary)..sqldatabase schema migration according to Flyway's naming convention (if relevant)