Use webpack bundled icon instead of GitHub hosted content#2803
Merged
Conversation
Signed-off-by: Chih-Wei Fang <dodo0822@gmail.com>
|
Thanks for opening your first pull request in the Marquez project! Please check out our contributing guidelines (https://github.com/MarquezProject/marquez/blob/main/CONTRIBUTING.md). |
✅ Deploy Preview for peppy-sprite-186812 canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2803 +/- ##
=========================================
Coverage 84.47% 84.47%
Complexity 1429 1429
=========================================
Files 251 251
Lines 6460 6460
Branches 299 299
=========================================
Hits 5457 5457
Misses 850 850
Partials 153 153 ☔ View full report in Codecov by Sentry. |
phixMe
approved these changes
Apr 26, 2024
|
Great job! Congrats on your first merged pull request in the Marquez project! |
jonathanpmoraes
referenced
this pull request
in nubank/NuMarquez
Feb 6, 2025
Signed-off-by: Chih-Wei Fang <dodo0822@gmail.com> Co-authored-by: Peter Hicks <phixMe@users.noreply.github.com> Co-authored-by: Willy Lulciuc <willy@datakin.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Currently the
Eventsitem inSidenavuses the icon hosted in GitHub, which may cause issue with strictContent-Security-Policysettings.Solution
One-line summary: use the icon SVG bundled by Webpack instead of linking to
raw.githubusercontent.com.Checklist
CHANGELOG.md(Depending on the change, this may not be necessary)..sqldatabase schema migration according to Flyway's naming convention (if relevant)