Skip to content

Use webpack bundled icon instead of GitHub hosted content#2803

Merged
wslulciuc merged 3 commits into
MarquezProject:mainfrom
dodo0822:bug/fix-remote-icon
Apr 29, 2024
Merged

Use webpack bundled icon instead of GitHub hosted content#2803
wslulciuc merged 3 commits into
MarquezProject:mainfrom
dodo0822:bug/fix-remote-icon

Conversation

@dodo0822

Copy link
Copy Markdown
Contributor

Problem

Currently the Events item in Sidenav uses the icon hosted in GitHub, which may cause issue with strict Content-Security-Policy settings.

image

Solution

One-line summary: use the icon SVG bundled by Webpack instead of linking to raw.githubusercontent.com.

Checklist

  • You've signed-off your work
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • You've included a one-line summary of your change for the CHANGELOG.md (Depending on the change, this may not be necessary).
  • You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)
  • You've included a header in any source code files (if relevant)

Signed-off-by: Chih-Wei Fang <dodo0822@gmail.com>
@boring-cyborg boring-cyborg Bot added the web label Apr 25, 2024
@boring-cyborg

boring-cyborg Bot commented Apr 25, 2024

Copy link
Copy Markdown

Thanks for opening your first pull request in the Marquez project! Please check out our contributing guidelines (https://github.com/MarquezProject/marquez/blob/main/CONTRIBUTING.md).

@netlify

netlify Bot commented Apr 25, 2024

Copy link
Copy Markdown

Deploy Preview for peppy-sprite-186812 canceled.

Name Link
🔨 Latest commit 59d0a5e
🔍 Latest deploy log https://app.netlify.com/sites/peppy-sprite-186812/deploys/663000865910b20008930c18

@codecov

codecov Bot commented Apr 25, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.47%. Comparing base (ab46957) to head (3d3c7af).

❗ Current head 3d3c7af differs from pull request most recent head 59d0a5e. Consider uploading reports for the commit 59d0a5e to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2803   +/-   ##
=========================================
  Coverage     84.47%   84.47%           
  Complexity     1429     1429           
=========================================
  Files           251      251           
  Lines          6460     6460           
  Branches        299      299           
=========================================
  Hits           5457     5457           
  Misses          850      850           
  Partials        153      153           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wslulciuc wslulciuc requested a review from phixMe April 26, 2024 17:34
@wslulciuc wslulciuc merged commit ec2cf88 into MarquezProject:main Apr 29, 2024
@boring-cyborg

boring-cyborg Bot commented Apr 29, 2024

Copy link
Copy Markdown

Great job! Congrats on your first merged pull request in the Marquez project!

jonathanpmoraes referenced this pull request in nubank/NuMarquez Feb 6, 2025
Signed-off-by: Chih-Wei Fang <dodo0822@gmail.com>
Co-authored-by: Peter Hicks <phixMe@users.noreply.github.com>
Co-authored-by: Willy Lulciuc <willy@datakin.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants