Column Lineage Linking and sticky tab titles#2805
Merged
Merged
Conversation
✅ Deploy Preview for peppy-sprite-186812 canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2805 +/- ##
=========================================
Coverage 84.47% 84.47%
Complexity 1429 1429
=========================================
Files 251 251
Lines 6460 6460
Branches 299 299
=========================================
Hits 5457 5457
Misses 850 850
Partials 153 153 ☔ View full report in Codecov by Sentry. |
Member
added 2 commits
May 1, 2024 12:57
…o feature/column-lineage-link
Member
Author
|
@davidsharp7 Good find on the description, I have rectified that display. I think we should modify the back button on the column lineage page to navigate back to the original dataset, or include a link to view the table lineage upon that page. But we'll tackle in another work stream. |
Member
|
Cool - yeah agree that's a good plan of attack and we can look at it later. |
davidsharp7
approved these changes
May 1, 2024
jonathanpmoraes
referenced
this pull request
in nubank/NuMarquez
Feb 6, 2025
* Adding in column lineage link. * Sticky placement on job details page. * Adding sticky to the job details tab. * Minor revisions to fonts, casing, and column lineage links. * nil guard. * Fixing description --------- Co-authored-by: phix <peter.hicks@astronomer.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Problem
Previously, we had a column lineage link at the top of the dataset. Now that has been moved to the column level and therefore will link to the column directly if available.
Also pegs the titles of jobs and datasets to the top of the drawer as an enhancement to keep context in focus for users of Marquez.
One-line summary: Sticky Titles and column lineage links in the table definition.
Checklist
CHANGELOG.md(Depending on the change, this may not be necessary)..sqldatabase schema migration according to Flyway's naming convention (if relevant)