Skip to content

Update JSON theme#2807

Merged
wslulciuc merged 1 commit into
mainfrom
feature/theme-json
May 1, 2024
Merged

Update JSON theme#2807
wslulciuc merged 1 commit into
mainfrom
feature/theme-json

Conversation

@phixMe

@phixMe phixMe commented May 1, 2024

Copy link
Copy Markdown
Member

Problem

This makes the JSON theme more in line with our brand.

image

Checklist

  • You've signed-off your work
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • You've included a one-line summary of your change for the CHANGELOG.md (Depending on the change, this may not be necessary).
  • You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)
  • You've included a header in any source code files (if relevant)

@boring-cyborg boring-cyborg Bot added the web label May 1, 2024
@netlify

netlify Bot commented May 1, 2024

Copy link
Copy Markdown

Deploy Preview for peppy-sprite-186812 canceled.

Name Link
🔨 Latest commit 67e3922
🔍 Latest deploy log https://app.netlify.com/sites/peppy-sprite-186812/deploys/6632c2c34c69a70008faf18e

@phixMe phixMe requested a review from wslulciuc May 1, 2024 22:34
@codecov

codecov Bot commented May 1, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.47%. Comparing base (6576fb3) to head (67e3922).

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2807   +/-   ##
=========================================
  Coverage     84.47%   84.47%           
  Complexity     1429     1429           
=========================================
  Files           251      251           
  Lines          6460     6460           
  Branches        299      299           
=========================================
  Hits           5457     5457           
  Misses          850      850           
  Partials        153      153           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wslulciuc wslulciuc left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯 🚀

@wslulciuc wslulciuc merged commit b29be3d into main May 1, 2024
@wslulciuc wslulciuc deleted the feature/theme-json branch May 1, 2024 22:36
@wslulciuc wslulciuc added the v2.UI label May 2, 2024
@wslulciuc wslulciuc added this to the 0.47.0 milestone May 2, 2024
jonathanpmoraes referenced this pull request in nubank/NuMarquez Feb 6, 2025
Co-authored-by: phix <peter.hicks@astronomer.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants