Skip to content

Various dataset tags improvements#2813

Merged
wslulciuc merged 1 commit into
mainfrom
bug/fix_tag_spacing
May 14, 2024
Merged

Various dataset tags improvements#2813
wslulciuc merged 1 commit into
mainfrom
bug/fix_tag_spacing

Conversation

@davidsharp7

@davidsharp7 davidsharp7 commented May 14, 2024

Copy link
Copy Markdown
Member

Problem

A few suggestions from the Marquez crew re the tags

  • change text focus from description to the autocomplete drop down when the edit tags dialog is opened
  • show that the auto complete is a drop down by using a carat.
  • stop the dataset tags column resizing in dataset field mode (may need to think about column name width)

Closes: #2811

Solution

Screenshot 2024-05-14 at 18 48 55 Screenshot 2024-05-14 at 18 51 01

One-line summary:

Various tag improvements

Checklist

  • You've signed-off your work
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • You've included a one-line summary of your change for the CHANGELOG.md (Depending on the change, this may not be necessary).
  • You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)
  • You've included a header in any source code files (if relevant)

Signed-off-by: sharpd <davidsharp7@gmail.com>
@boring-cyborg boring-cyborg Bot added the web label May 14, 2024
@netlify

netlify Bot commented May 14, 2024

Copy link
Copy Markdown

Deploy Preview for peppy-sprite-186812 canceled.

Name Link
🔨 Latest commit 85063da
🔍 Latest deploy log https://app.netlify.com/sites/peppy-sprite-186812/deploys/66430a0c5313df0008564f4e

@codecov

codecov Bot commented May 14, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.57%. Comparing base (61927c2) to head (85063da).

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2813   +/-   ##
=========================================
  Coverage     84.57%   84.57%           
  Complexity     1441     1441           
=========================================
  Files           251      251           
  Lines          6503     6503           
  Branches        302      302           
=========================================
  Hits           5500     5500           
  Misses          850      850           
  Partials        153      153           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidsharp7 davidsharp7 marked this pull request as ready for review May 14, 2024 17:59
@wslulciuc wslulciuc added this to the 0.47.0 milestone May 14, 2024

@wslulciuc wslulciuc left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 🥇

@wslulciuc wslulciuc merged commit 226d275 into main May 14, 2024
@wslulciuc wslulciuc deleted the bug/fix_tag_spacing branch May 14, 2024 18:40
jonathanpmoraes referenced this pull request in nubank/NuMarquez Feb 6, 2025
Signed-off-by: sharpd <davidsharp7@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Extra spacing when toggling "Show Field Tags"

2 participants