Add Job tagging to UI#2837
Conversation
Signed-off-by: sharpd <davidsharp7@gmail.com>
✅ Deploy Preview for peppy-sprite-186812 canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2837 +/- ##
=========================================
Coverage 84.74% 84.74%
Complexity 1456 1456
=========================================
Files 253 253
Lines 6562 6562
Branches 305 305
=========================================
Hits 5561 5561
Misses 850 850
Partials 151 151 ☔ View full report in Codecov by Sentry. |
Signed-off-by: sharpd <davidsharp7@gmail.com>
| setTagDescription(selectedTagData ? selectedTagData.description : 'No Description') | ||
| } | ||
|
|
||
| const handleDescriptionChange = (event: any) => { |
There was a problem hiding this comment.
I think you can have an explicit type here, right?
| case ADD_JOB_TAG: | ||
| return { | ||
| ...state, | ||
| } | ||
| case ADD_JOB_TAG_SUCCESS: | ||
| return { | ||
| ...state, | ||
| } | ||
| case DELETE_JOB_TAG: | ||
| return { | ||
| ...state, | ||
| } | ||
| case DELETE_JOB_TAG_SUCCESS: | ||
| return { | ||
| ...state, | ||
| } |
There was a problem hiding this comment.
Do we need any of these, if they just reflect the same state?
There was a problem hiding this comment.
Yip happy to remove.
| const handleTagDescChange = (_event: any, value: string) => { | ||
| const selectedTagData = tagData.find((tag) => tag.name === value) | ||
| setListTag(value) | ||
| setTagDescription(selectedTagData ? selectedTagData.description : 'No Description') |
There was a problem hiding this comment.
"No description" is kind of a description in and of itself, is this what you want out of this, would you prefer if it was just empty?
There was a problem hiding this comment.
Yeah that's my data hat talking - can leave blank.
| <MQText subheading bottomMargin> | ||
| Description | ||
| </MQText> |
There was a problem hiding this comment.
I was thinking we may want to use the label prop on these, maybe it would work a bit better with the design system. I could be wrong.
Signed-off-by: sharpd <davidsharp7@gmail.com>
Signed-off-by: sharpd <davidsharp7@gmail.com>
Signed-off-by: sharpd <davidsharp7@gmail.com>
Signed-off-by: sharpd <davidsharp7@gmail.com>
phixMe
left a comment
phixMe
left a comment
There was a problem hiding this comment.
Thanks @davidsharp7 for driving this effort forward!
|
Always an opportunity to learn more stuff! |
* Add job tagging to UI Signed-off-by: sharpd <davidsharp7@gmail.com> * update reducers Signed-off-by: sharpd <davidsharp7@gmail.com> * minor tweaks based on feedback Signed-off-by: sharpd <davidsharp7@gmail.com> * remove uneeded code Signed-off-by: sharpd <davidsharp7@gmail.com> * lint and remove uneeded code Signed-off-by: sharpd <davidsharp7@gmail.com> * update tag dialog to use label switch Signed-off-by: sharpd <davidsharp7@gmail.com> --------- Signed-off-by: sharpd <davidsharp7@gmail.com>
3 participants
Problem
Currently we can tag jobs via the API but not in UI.
Closes: #2817
Solution
Copy the basic infrastructure for tagging setting but apply it to the Job Detail page in the UI.
One-line summary:
Add job tagging to UI
Checklist
CHANGELOG.md(Depending on the change, this may not be necessary)..sqldatabase schema migration according to Flyway's naming convention (if relevant)