web: Add env variable for setting up the frontend port#2838
Merged
Conversation
|
Thanks for opening your first pull request in the Marquez project! Please check out our contributing guidelines (https://github.com/MarquezProject/marquez/blob/main/CONTRIBUTING.md). |
✅ Deploy Preview for peppy-sprite-186812 canceled.
|
bidlako
changed the title
phixMe
reviewed
Jun 21, 2024
|
|
||
| app.listen(3000, function() { | ||
| console.log('App listening on port 3000!') | ||
| app.listen(port, function() { |
Member
There was a problem hiding this comment.
Is there a default we need to set for this?
Member
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2838 +/- ##
=========================================
Coverage 84.77% 84.77%
Complexity 1470 1470
=========================================
Files 256 256
Lines 6626 6626
Branches 308 308
=========================================
Hits 5617 5617
Misses 856 856
Partials 153 153 ☔ View full report in Codecov by Sentry. |
phixMe
approved these changes
Aug 9, 2024
phixMe
left a comment
phixMe
left a comment
Member
There was a problem hiding this comment.
I pulled this down and verified, thanks for the change.
|
Great job! Congrats on your first merged pull request in the Marquez project! |
alaturqua
pushed a commit
to alaturqua/marquez
that referenced
this pull request
Aug 21, 2024
…t#2239) (MarquezProject#2838) Co-authored-by: Willy Lulciuc <willy@datakin.com> Signed-off-by: Isa Inalcik <isa.inalcik@gmail.com>
alaturqua
pushed a commit
to alaturqua/marquez
that referenced
this pull request
Aug 21, 2024
…t#2239) (MarquezProject#2838) Co-authored-by: Willy Lulciuc <willy@datakin.com> Signed-off-by: Isa Inalcik <isa.inalcik@gmail.com>
jonathanpmoraes
referenced
this pull request
in nubank/NuMarquez
Feb 6, 2025
…t#2239) (#2838) Co-authored-by: Willy Lulciuc <willy@datakin.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replacing the hardcoded port with env variable.