version history: deduplicate the versions displayed#2854
Merged
phixMe merged 3 commits intoJul 22, 2024
Conversation
Signed-off-by: Namizata <namizata.sangare@decathlon.com>
|
Thanks for opening your first pull request in the Marquez project! Please check out our contributing guidelines (https://github.com/MarquezProject/marquez/blob/main/CONTRIBUTING.md). |
✅ Deploy Preview for peppy-sprite-186812 canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2854 +/- ##
=========================================
Coverage 84.74% 84.74%
Complexity 1456 1456
=========================================
Files 253 253
Lines 6562 6562
Branches 305 305
=========================================
Hits 5561 5561
Misses 850 850
Partials 151 151 ☔ View full report in Codecov by Sentry. |
phixMe
reviewed
Jul 19, 2024
| .build())) | ||
| .outputs(Collections.emptyList()) | ||
| .build(); | ||
| System.out.println("event is " + lineageEvent); |
Contributor
Author
There was a problem hiding this comment.
i pushed a new version removing the log statement
phixMe
reviewed
Jul 19, 2024
phixMe
left a comment
Member
There was a problem hiding this comment.
Thanks for the change, happy to merge after the log is removed!
Signed-off-by: Namizata <namizata.sangare@decathlon.com>
|
Great job! Congrats on your first merged pull request in the Marquez project! |
jonathanpmoraes
referenced
this pull request
in nubank/NuMarquez
Feb 6, 2025
* version history: deduplicate the versions displayed Signed-off-by: Namizata <namizata.sangare@decathlon.com> * remove log from test Signed-off-by: Namizata <namizata.sangare@decathlon.com> --------- Signed-off-by: Namizata <namizata.sangare@decathlon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In the version history, a dataset will sometimes have the same version displayed multiple times.

After investigating, i found out that this comes from the join clause between the dataset_versions and datasets_view in this function. The symlinks are included in the datasets_view using the same uuid as the dataset and so are displayed in the same logic as the primary dataset.
Solution
For the same dataset in the above example we have now this display

One-line summary:
Checklist
CHANGELOG.md(Depending on the change, this may not be necessary)..sqldatabase schema migration according to Flyway's naming convention (if relevant)