Web: encode job name in API requests#2866
Merged
Merged
Conversation
✅ Deploy Preview for peppy-sprite-186812 canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2866 +/- ##
============================================
+ Coverage 84.80% 85.47% +0.67%
+ Complexity 1469 1228 -241
============================================
Files 256 213 -43
Lines 6615 5619 -996
Branches 308 268 -40
============================================
- Hits 5610 4803 -807
+ Misses 852 692 -160
+ Partials 153 124 -29 ☔ View full report in Codecov by Sentry. |
1b86cf7 to
a3b65bc
Compare
Signed-off-by: Martynov Maxim <martinov_m_s_@mail.ru>
a3b65bc to
49bcd9c
Compare
phixMe
approved these changes
Aug 5, 2024
phixMe
left a comment
Member
There was a problem hiding this comment.
Thanks, this is the kind of issue that we keep getting back to with every path we have. We really need some unit test coverage on this. @wslulciuc We should come up with something here.
jonathanpmoraes
referenced
this pull request
in nubank/NuMarquez
Feb 6, 2025
Signed-off-by: Martynov Maxim <martinov_m_s_@mail.ru>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
After upgrading to 0.48 opening some job details lead to 404 errors.
This is because I have job names with slashes, like
my/session/name, resulting API query to look like this:http://localhost:8080/api/v1/namespaces/yarn%3A%2F%2Fsomecluster/jobs/my/session/name.execute_insert_into_hadoop_fs_relation_commandBut it should be:
http://localhost:8080/api/v1/namespaces/yarn%3A%2F%2Fsomecluster/jobs/my%2Fsession%2Fname.execute_insert_into_hadoop_fs_relation_commandSame could be applied to dataset, tag or field names.
Solution
One-line summary:
Urlencode job, dataset, tag and field names while sending API request.
Checklist
CHANGELOG.md(Depending on the change, this may not be necessary)..sqldatabase schema migration according to Flyway's naming convention (if relevant)