add common labels to replicasets#2877
Merged
Merged
Conversation
|
Thanks for opening your first pull request in the Marquez project! Please check out our contributing guidelines (https://github.com/MarquezProject/marquez/blob/main/CONTRIBUTING.md). |
✅ Deploy Preview for peppy-sprite-186812 canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2877 +/- ##
=========================================
Coverage 83.28% 83.28%
Complexity 1477 1477
=========================================
Files 259 259
Lines 6785 6785
Branches 313 313
=========================================
Hits 5651 5651
Misses 977 977
Partials 157 157 ☔ View full report in Codecov by Sentry. |
alaturqua
force-pushed
the
main
branch
4 times, most recently
from
b1eaf7b to
946f706
Compare
alaturqua
force-pushed
the
main
branch
2 times, most recently
from
a547d62 to
c4df215
Compare
alaturqua
force-pushed
the
main
branch
2 times, most recently
from
09bc5a8 to
d2fb0c0
Compare
Signed-off-by: Isa Inalcik <isa.inalcik@gmail.com>
|
Great job! Congrats on your first merged pull request in the Marquez project! |
jonathanpmoraes
referenced
this pull request
in nubank/NuMarquez
Feb 6, 2025
Signed-off-by: Isa Inalcik <isa.inalcik@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Replicasets were missing common labels. This PR adds them to deployments.
Solution
Replicasets were missing common labels. This PR adds them to deployments.
One-line summary:
Replicasets were missing common labels. This PR adds them to deployments.