Skip to content

Add migration with on cascade delete constraint#2878

Merged
wslulciuc merged 2 commits into
MarquezProject:mainfrom
mattwparas:bug/job-facets-foreign-key-constraints
Aug 23, 2024
Merged

Add migration with on cascade delete constraint#2878
wslulciuc merged 2 commits into
MarquezProject:mainfrom
mattwparas:bug/job-facets-foreign-key-constraints

Conversation

@mattwparas

@mattwparas mattwparas commented Aug 22, 2024

Copy link
Copy Markdown
Contributor

Problem

Closes: #2871

Solution

I am occasionally running into this #2871 - after reviewing the migrations it appears that a cascade delete constraint was missing. I believe this is a backwards compatible change. The problem manifests itself when the retention job runs, and causes the retention jobs to quit and not continue since it can't move forward.

One-line summary:

Checklist

  • You've signed-off your work
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • You've included a one-line summary of your change for the CHANGELOG.md (Depending on the change, this may not be necessary).
  • You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)
  • You've included a header in any source code files (if relevant)

Signed-off-by: Matt Paras <matthewparas2020@u.northwestern.edu>
@boring-cyborg boring-cyborg Bot added the api API layer changes label Aug 22, 2024
@boring-cyborg

boring-cyborg Bot commented Aug 22, 2024

Copy link
Copy Markdown

Thanks for opening your first pull request in the Marquez project! Please check out our contributing guidelines (https://github.com/MarquezProject/marquez/blob/main/CONTRIBUTING.md).

@netlify

netlify Bot commented Aug 22, 2024

Copy link
Copy Markdown

Deploy Preview for peppy-sprite-186812 canceled.

Name Link
🔨 Latest commit b6dec32
🔍 Latest deploy log https://app.netlify.com/sites/peppy-sprite-186812/deploys/66c8acf31cc94d00088e71d2

@codecov

codecov Bot commented Aug 22, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.28%. Comparing base (ead480b) to head (b6dec32).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2878   +/-   ##
=========================================
  Coverage     83.28%   83.28%           
  Complexity     1477     1477           
=========================================
  Files           259      259           
  Lines          6785     6785           
  Branches        313      313           
=========================================
  Hits           5651     5651           
  Misses          977      977           
  Partials        157      157           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wslulciuc wslulciuc left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@wslulciuc wslulciuc enabled auto-merge (squash) August 23, 2024 15:38
@wslulciuc wslulciuc merged commit 88cc969 into MarquezProject:main Aug 23, 2024
@boring-cyborg

boring-cyborg Bot commented Aug 23, 2024

Copy link
Copy Markdown

Great job! Congrats on your first merged pull request in the Marquez project!

@wslulciuc wslulciuc added this to the 0.50.0 milestone Aug 23, 2024
jonathanpmoraes referenced this pull request in nubank/NuMarquez Feb 6, 2025
Signed-off-by: Matt Paras <matthewparas2020@u.northwestern.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api API layer changes

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Foreign key constraint error with db retention job

2 participants