Add migration with on cascade delete constraint#2878
Merged
wslulciuc merged 2 commits intoAug 23, 2024
Merged
Conversation
Signed-off-by: Matt Paras <matthewparas2020@u.northwestern.edu>
|
Thanks for opening your first pull request in the Marquez project! Please check out our contributing guidelines (https://github.com/MarquezProject/marquez/blob/main/CONTRIBUTING.md). |
✅ Deploy Preview for peppy-sprite-186812 canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2878 +/- ##
=========================================
Coverage 83.28% 83.28%
Complexity 1477 1477
=========================================
Files 259 259
Lines 6785 6785
Branches 313 313
=========================================
Hits 5651 5651
Misses 977 977
Partials 157 157 ☔ View full report in Codecov by Sentry. |
|
Great job! Congrats on your first merged pull request in the Marquez project! |
jonathanpmoraes
referenced
this pull request
in nubank/NuMarquez
Feb 6, 2025
Signed-off-by: Matt Paras <matthewparas2020@u.northwestern.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Closes: #2871
Solution
I am occasionally running into this #2871 - after reviewing the migrations it appears that a cascade delete constraint was missing. I believe this is a backwards compatible change. The problem manifests itself when the retention job runs, and causes the retention jobs to quit and not continue since it can't move forward.
One-line summary:
Checklist
CHANGELOG.md(Depending on the change, this may not be necessary)..sqldatabase schema migration according to Flyway's naming convention (if relevant)