[FIX] Column lineage query with null namespace and name#2881
Merged
wslulciuc merged 1 commit intoAug 27, 2024
Merged
Conversation
✅ Deploy Preview for peppy-sprite-186812 canceled.
|
Signed-off-by: sophiely <ly.sophie200@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2881 +/- ##
=========================================
Coverage 83.28% 83.28%
Complexity 1477 1477
=========================================
Files 259 259
Lines 6785 6785
Branches 313 313
=========================================
Hits 5651 5651
Misses 977 977
Partials 157 157 ☔ View full report in Codecov by Sentry. |
jonathanpmoraes
referenced
this pull request
in nubank/NuMarquez
Feb 6, 2025
Signed-off-by: sophiely <ly.sophie200@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Closes: #2875
In some case the input dataset used seems not to be in dataset_views table so when joining the two tables it results in null for namespace and name and make the list dataset endpoint fail.
dataset_views only contains the latest dataset version so if the column lineage is created with an old version, this old version will ne be in the dataset_view and then results in an empty namespace and name.
Solution
We can get the namespace and name in the dataset_versions table to make sure to have all the version of a dataset.
Checklist
CHANGELOG.md(Depending on the change, this may not be necessary)..sqldatabase schema migration according to Flyway's naming convention (if relevant)