Skip to content

[FIX] Column lineage query with null namespace and name#2881

Merged
wslulciuc merged 1 commit into
MarquezProject:mainfrom
sophiely:fix/column-lineage-query-return-null-for-namespace
Aug 27, 2024
Merged

[FIX] Column lineage query with null namespace and name#2881
wslulciuc merged 1 commit into
MarquezProject:mainfrom
sophiely:fix/column-lineage-query-return-null-for-namespace

Conversation

@sophiely

@sophiely sophiely commented Aug 26, 2024

Copy link
Copy Markdown
Contributor

Problem

Closes: #2875

In some case the input dataset used seems not to be in dataset_views table so when joining the two tables it results in null for namespace and name and make the list dataset endpoint fail.
dataset_views only contains the latest dataset version so if the column lineage is created with an old version, this old version will ne be in the dataset_view and then results in an empty namespace and name.

Solution

We can get the namespace and name in the dataset_versions table to make sure to have all the version of a dataset.

Checklist

  • You've signed-off your work
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • You've included a one-line summary of your change for the CHANGELOG.md (Depending on the change, this may not be necessary).
  • You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)
  • You've included a header in any source code files (if relevant)

@boring-cyborg boring-cyborg Bot added the api API layer changes label Aug 26, 2024
@netlify

netlify Bot commented Aug 26, 2024

Copy link
Copy Markdown

Deploy Preview for peppy-sprite-186812 canceled.

Name Link
🔨 Latest commit 9f60d04
🔍 Latest deploy log https://app.netlify.com/sites/peppy-sprite-186812/deploys/66ccab7d1e01560008d2a5f0

Signed-off-by: sophiely <ly.sophie200@gmail.com>
@codecov

codecov Bot commented Aug 26, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.28%. Comparing base (915aff3) to head (9f60d04).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2881   +/-   ##
=========================================
  Coverage     83.28%   83.28%           
  Complexity     1477     1477           
=========================================
  Files           259      259           
  Lines          6785     6785           
  Branches        313      313           
=========================================
  Hits           5651     5651           
  Misses          977      977           
  Partials        157      157           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wslulciuc wslulciuc left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯 💯

@wslulciuc wslulciuc merged commit 38bc4ff into MarquezProject:main Aug 27, 2024
@wslulciuc wslulciuc added this to the 0.50.0 milestone Aug 27, 2024
jonathanpmoraes referenced this pull request in nubank/NuMarquez Feb 6, 2025
Signed-off-by: sophiely <ly.sophie200@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api API layer changes

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

Column lineage query returning null for namespace and name

2 participants