Skip to content

Web: Allow nullable columns and handle it accordingly#2896

Merged
wslulciuc merged 1 commit into
mainfrom
fix/nullable-column-field
Sep 12, 2024
Merged

Web: Allow nullable columns and handle it accordingly#2896
wslulciuc merged 1 commit into
mainfrom
fix/nullable-column-field

Conversation

@phixMe

@phixMe phixMe commented Sep 12, 2024

Copy link
Copy Markdown
Member

Problem

We would display and empty oval in the case that column types were missing, this will display N/A in the case that we encounter it.

Checklist

  • You've signed-off your work
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • You've included a one-line summary of your change for the CHANGELOG.md (Depending on the change, this may not be necessary).
  • You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)
  • You've included a header in any source code files (if relevant)

@boring-cyborg boring-cyborg Bot added the web label Sep 12, 2024
@netlify

netlify Bot commented Sep 12, 2024

Copy link
Copy Markdown

Deploy Preview for peppy-sprite-186812 canceled.

Name Link
🔨 Latest commit dabf20f
🔍 Latest deploy log https://app.netlify.com/sites/peppy-sprite-186812/deploys/66e32d2b21608500094e66e7

@codecov

codecov Bot commented Sep 12, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.97%. Comparing base (d407e66) to head (dabf20f).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2896   +/-   ##
=========================================
  Coverage     82.97%   82.97%           
  Complexity     1485     1485           
=========================================
  Files           264      264           
  Lines          6849     6849           
  Branches        315      315           
=========================================
  Hits           5683     5683           
  Misses         1011     1011           
  Partials        155      155           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wslulciuc wslulciuc merged commit 239ddf5 into main Sep 12, 2024
@wslulciuc wslulciuc deleted the fix/nullable-column-field branch September 12, 2024 18:40
jonathanpmoraes referenced this pull request in nubank/NuMarquez Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants