Skip to content

Latest runs for jobs#2901

Merged
wslulciuc merged 7 commits into
mainfrom
feature/latest-runs
Oct 8, 2024
Merged

Latest runs for jobs#2901
wslulciuc merged 7 commits into
mainfrom
feature/latest-runs

Conversation

@phixMe

@phixMe phixMe commented Sep 27, 2024

Copy link
Copy Markdown
Member

Problem

image

Power the legacy job runs view for the new dashboard.

  • Adds 10 most recently run jobs
  • Query param for runState

One-line summary: Extra field for latest runs.

Checklist

  • You've signed-off your work
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • You've included a one-line summary of your change for the CHANGELOG.md (Depending on the change, this may not be necessary).
  • You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)
  • You've included a header in any source code files (if relevant)

@boring-cyborg boring-cyborg Bot added api API layer changes spec labels Sep 27, 2024
@netlify

netlify Bot commented Sep 27, 2024

Copy link
Copy Markdown

Deploy Preview for peppy-sprite-186812 canceled.

Name Link
🔨 Latest commit 32cbbb1
🔍 Latest deploy log https://app.netlify.com/sites/peppy-sprite-186812/deploys/67056dbe7c2924000845f7c0

@phixMe phixMe changed the title feature/latest-runs Latest runs for jobs Sep 28, 2024
@codecov

codecov Bot commented Sep 28, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 95.65217% with 1 line in your changes missing coverage. Please review.

Project coverage is 83.11%. Comparing base (1d90f18) to head (32cbbb1).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
api/src/main/java/marquez/api/JobResource.java 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2901   +/-   ##
=========================================
  Coverage     83.10%   83.11%           
+ Complexity     1487     1486    -1     
=========================================
  Files           264      264           
  Lines          6849     6857    +8     
  Branches        315      316    +1     
=========================================
+ Hits           5692     5699    +7     
  Misses         1002     1002           
- Partials        155      156    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@phixMe phixMe marked this pull request as ready for review September 29, 2024 22:43
Comment thread api/src/main/java/marquez/api/JobResource.java Outdated
Comment thread api/src/main/java/marquez/db/JobDao.java Outdated
Signed-off-by: phixMe <peter.hicks@pdtechsolutions.com>

@wslulciuc wslulciuc left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@wslulciuc wslulciuc enabled auto-merge (squash) October 8, 2024 17:36
@wslulciuc wslulciuc merged commit 65d57f7 into main Oct 8, 2024
@wslulciuc wslulciuc deleted the feature/latest-runs branch October 8, 2024 17:56
@wslulciuc wslulciuc added this to the 0.50.0 milestone Oct 11, 2024
jonathanpmoraes referenced this pull request in nubank/NuMarquez Feb 6, 2025
* Latest runs coming down.

* Adding query param for job listing.

* Editing tests.

* Bringing in jobs without a run state for tests.

* Spotless

* Moving to list for lastRunStates.

Signed-off-by: phixMe <peter.hicks@pdtechsolutions.com>

---------

Signed-off-by: phixMe <peter.hicks@pdtechsolutions.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api API layer changes spec

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

2 participants