Skip to content

Updated event count chip rendering#2916

Merged
phixMe merged 1 commit into
MarquezProject:mainfrom
NisargChokshi45:main
Oct 3, 2024
Merged

Updated event count chip rendering#2916
phixMe merged 1 commit into
MarquezProject:mainfrom
NisargChokshi45:main

Conversation

@NisargChokshi45

Copy link
Copy Markdown
Contributor

Problem

👋 Thanks for opening a pull request! Please include a brief summary of the problem your change is trying to solve, or bug fix. If your change fixes a bug or you'd like to provide context on why you're making the change, please link the issue as follows:

Closes: #ISSUE-NUMBER

Solution

Please describe your change as it relates to the problem, or bug fix, as well as any dependencies. If your change requires a database schema migration, please describe the schema modification(s) and whether it's a backwards-incompatible or backwards-compatible change.

Note: All database schema changes require discussion. Please link the issue for context.

One-line summary: Updated event count chip rendering

Checklist

  • You've signed-off your work
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • You've included a one-line summary of your change for the CHANGELOG.md (Depending on the change, this may not be necessary).
  • You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)
  • You've included a header in any source code files (if relevant)

@boring-cyborg boring-cyborg Bot added the web label Oct 3, 2024
@boring-cyborg

boring-cyborg Bot commented Oct 3, 2024

Copy link
Copy Markdown

Thanks for opening your first pull request in the Marquez project! Please check out our contributing guidelines (https://github.com/MarquezProject/marquez/blob/main/CONTRIBUTING.md).

@netlify

netlify Bot commented Oct 3, 2024

Copy link
Copy Markdown

Deploy Preview for peppy-sprite-186812 canceled.

Name Link
🔨 Latest commit 6ee3286
🔍 Latest deploy log https://app.netlify.com/sites/peppy-sprite-186812/deploys/66fed97d3b232b0008a018d4

@NisargChokshi45

Copy link
Copy Markdown
Contributor Author

Hey @wslulciuc @phixMe, can you please review this PR ?
If possible, can we also add a label named hacktoberfest in the PR ?

@codecov

codecov Bot commented Oct 3, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.10%. Comparing base (9e8e3d3) to head (6ee3286).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2916   +/-   ##
=========================================
  Coverage     83.10%   83.10%           
  Complexity     1487     1487           
=========================================
  Files           264      264           
  Lines          6849     6849           
  Branches        315      315           
=========================================
  Hits           5692     5692           
  Misses         1002     1002           
  Partials        155      155           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wslulciuc wslulciuc requested a review from phixMe October 3, 2024 19:07
@wslulciuc wslulciuc added the hacktoberfest Let's celebrate open source together! label Oct 3, 2024
@wslulciuc

Copy link
Copy Markdown
Member

@NisargChokshi45, done! I've also added @phixMe as the reviewer.

@phixMe phixMe left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. Please fill in the Description and Solution for your next PR. I one sentence description would be fine for something like this.

@phixMe phixMe merged commit 1d90f18 into MarquezProject:main Oct 3, 2024
@boring-cyborg

boring-cyborg Bot commented Oct 3, 2024

Copy link
Copy Markdown

Great job! Congrats on your first merged pull request in the Marquez project!

@wslulciuc wslulciuc added this to the 0.50.0 milestone Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hacktoberfest Let's celebrate open source together! web

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

3 participants